fix(postgres-operator/deployment): Set 'nindent' to 8 for 'extraEnvs' #2783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That would be nice. We also hit that. |
FxKu
reviewed
Oct 28, 2024
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v2 | |||
| name: postgres-operator | |||
| version: 1.13.0 | |||
There was a problem hiding this comment.
this will be bumped to 1.14.0. We have no branching in place to create a bugfix release for 1.13.0. Too many feature already merged to main trunk.
There was a problem hiding this comment.
I wanted to keep it at 1.13.0 for now, but ok, we can also set to 1.14.0.
|
Thanks for providing the fix. Could you please keep the version on the Chart.yaml? (see my comment) |
d6e21c1 to
1769db6
Compare
eabde58 to
18e7c67
Compare
|
👍 |
hughcapet
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a template error in
postgres-operator/deployment.If you want to use
extraEnvsinvalues.yaml, the current indentation forextraEnvscauses the resultingdeployment.yamlto break due to incorrect indentation.The nindent value has been updated from
12to8.Result with the old values.yaml (nindent 12):
Result with the new nindent set to 8:
Bumped Chart.yaml version to 1.13.1 but I'm not sure if it's correct