Only check maintenance window for upgrade after pg version recheck #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
reviewed
Jan 17, 2025
pkg/cluster/majorversionupgrade.go
Outdated
| @@ -175,13 +172,21 @@ func (c *Cluster) majorVersionUpgrade() error { | |||
| } | |||
| c.logger.Infof("recheck cluster version is already up to date. current: %d, min desired: %d", c.currentMajorVersion, desiredVersion) | |||
| return nil | |||
| } else if isStandbyCluster { | |||
| c.logger.Errorf("skipping major version upgrade for %s/%s standby cluster. Re-deploy standby cluster with the required Postgres version specified", c.Namespace, c.Name) | |||
There was a problem hiding this comment.
shouldn't this be changed to Warnf maybe (even if it was also Error before)?
hughcapet
commented
Jan 17, 2025
|
👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we avoid misleading "skipping major version upgrade, not in maintenance window" log line when
c.currentMajorVersionis not initialized (==0)