Thanks for submitting!

This is a good start -- three suggestions:

• Report.details should be changed to Report.minutes to match the API
• The docstring on Report should be updated to someting like: Contains all API methods relating to Reports.
• The start_date and end_date kwargs are assumed to be strings -- it would probably be better to allow datetime objects to be passed in, then convert them to "YYYY-MM-DD" strings before sending the request to Zencoder.

If you want to make those suggested changes, please go for it! Otherwise, I'll merge your PR and make the changes myself.

Cheers
Alex

Excellent, I'll make those changes if you don't mind and I'll submit them in a few days, if that's cool?

Thanks for all the feedback, they definitely make sense, I just wanted to get something quick and dirty working to begin with...

Thanks,
-Mark

On Monday, October 29, 2012 at 7:31 PM, Alex Schworer wrote:

Thanks for submitting!
This is a good start -- three suggestions:
Report.details should be changed to Report.minutes to match the API
The docstring on Report should be updated to someting like: Contains all API methods relating to Reports.
The start_date and end_date kwargs are assumed to be strings -- it would probably be better to allow datetime objects to be passed in, then convert them to "YYYY-MM-DD" strings before sending the request to Zencoder.

If you want to make those suggested changes, please go for it! Otherwise, I'll merge your PR and make the changes myself.
Cheers
Alex

—
Reply to this email directly or view it on GitHub (#15 (comment)).

Totally cool -- take your time for the changes. If you get stuck or pulled off to something else, let me know and I'll take it over.

It's taken some time, but I've added in these changes. Let me know what you think, hopefully it works to your requirements.

Cheers,
-Mark

Thanks for making these changes, I should be able to pull these in pretty easily.

Cool, let me know if there are any issues or if more testing is required.

Cheers,
-Mark

On Sat, Feb 23, 2013 at 4:07 PM, Alex Schworer notifications@github.comwrote:

Thanks for making these changes, I should be able to pull these in pretty
easily.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/15#issuecomment-13997786.

Merged -- thank you!