This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Support user-defined error codes #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the client code to supply his own domain-specific error codes. In my case these were expired account, disabled account, and password not set up. It is also necessary for the client to supplement $this->messageTemplates and extend the Result class but this is already possible.
|
This was the easiest way to extend it but it's a bit convoluted. The result error code is mapped to validator error code which is mapped to a message template which is overridden by a message if supplied. The messages in the Result object were and are still ignored by the validator. Alternative suggestions are welcome. |
Merged
8 tasks
|
Implemented with #47 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the client code to supply his own domain-specific error codes. In my case these were expired account, disabled account, and password not set up.
It is also necessary for the client to supplement $this->messageTemplates and extend the Result class but this is already possible.
Are you creating a new feature?
developbranch, and submit against that branch.CHANGELOG.mdentry for the new feature.Is this related to quality assurance?
Yes. Because my users are often confused by the generic error message when they can't log in