This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Pass with append string still valid #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xerkus
reviewed
May 13, 2019
|
|
||
| public function testResolveNoValidPasswordWithPrependSign() | ||
| { | ||
| list($username, $password) = explode(':', base64_decode(base64_encode('admink:admin').'X')); |
There was a problem hiding this comment.
This test is pretty much invalid. base64_decode drops X here because it does not form full octet.
|
What you show here apears to be result of non-strict mode of |
|
This repository has been closed and moved to laminas/laminas-authentication; a new issue has been opened at laminas/laminas-authentication#1. |
|
This repository has been moved to laminas/laminas-authentication. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding string to correct basic token still allow to pass token when using crypt.