Feature - extended CS sniffs #109
Conversation
|
In this PR I've included some changes, probably it should be separate: classes @Ocramius is there any other purpose of this not used interface, or I am right, and it should be used in these two classes? |
| @@ -11,33 +11,33 @@ | |||
|
|
|||
| use Zend\Code\Reflection\ClassReflection; | |||
|
|
|||
| class ClassGenerator extends AbstractGenerator | |||
| class ClassGenerator extends AbstractGenerator implements TraitUsageInterface | |||
There was a problem hiding this comment.
Uhhh, unsure why this class should ever need TraitUsageInterface :-\
There was a problem hiding this comment.
@Ocramius Please check out my comment #109 (comment)
Please note that this class has all methods from this interface and in doc comments of these methods we had:
@inherit Zend\Code\Generator\TraitUsageInterface
what I've changed to @inheritDoc (but this is fine only when class has 'parent class' or 'interface' with these methods)
| <exclude-pattern>src/Scanner/ClassScanner.php</exclude-pattern> | ||
| <exclude-pattern>src/Scanner/DocBlockScanner.php</exclude-pattern> | ||
| <exclude-pattern>src/Scanner/MethodScanner.php</exclude-pattern> | ||
| <exclude-pattern>src/Scanner/TokenArrayScanner.php</exclude-pattern> |
There was a problem hiding this comment.
In these files we have variables like: $MACRO_STREAM_ADVANCE_CHAR. Probably we can rename all these variables there and then remove this exception here. Or is there any other reason why we have uppercase, underscore separated variable names there?
|
I manually merged this patch to |
Please see: zendframework/zend-coding-standard#1