Add omit property value type #131
Conversation
There was a problem hiding this comment.
@janvernieuwe since this is an improvement, could you please target develop?
src/Generator/PropertyGenerator.php
Outdated
| return $output . ';'; | ||
| } | ||
|
|
||
| $output .= ' = ' . ($defaultValue !== null ? $defaultValue->generate() : 'null;'); |
src/Generator/ValueGenerator.php
Outdated
| @@ -50,6 +50,7 @@ class ValueGenerator extends AbstractGenerator | |||
| const TYPE_CONSTANT = 'constant'; | |||
| const TYPE_NULL = 'null'; | |||
| const TYPE_OBJECT = 'object'; | |||
| const TYPE_OMIT = 'omit'; | |||
src/Generator/PropertyGenerator.php
Outdated
| $output .= $this->indentation . $this->getVisibility() . ($this->isStatic() ? ' static' : '') . ' $' . $name; | ||
|
|
||
| if ($this->defaultValue instanceof PropertyValueGenerator && | ||
| $this->defaultValue->getType() === ValueGenerator::TYPE_OMIT) { |
There was a problem hiding this comment.
$this->defaultValue->omitType() instead - that gets rid of the ugly constant too ;-)
| public function testOmitType() | ||
| { | ||
| $property = new PropertyGenerator('test', null); | ||
| $property->setDefaultValue(null, ValueGenerator::TYPE_OMIT); |
There was a problem hiding this comment.
That's really really ugly. Would rather prefer ->removeDefaultValue() or ->omitDefaultValue() instead of having a ValueGenerator with special purposes (there is a big impedance between the concept of a value generator and the concept of a lack of value)
There was a problem hiding this comment.
I'll remove the constant, and move it to a property in the PropertyGenerator.
There was a problem hiding this comment.
If you look at the other comments, I suggest not touching the PropertyGenerator at all
|
I'm not too sure about how omitDefaultValue is better implemented, see the last commit. |
|
@janvernieuwe the idea is to have the |
use a property instead of constant
|
Thanks @janvernieuwe \o/ |
Fixes #28