Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Fixed thrown exception class in MethodScanner#setVisibility() #145

Closed
wants to merge 1 commit into from
Closed

Fixed thrown exception class in MethodScanner#setVisibility() #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Scanner/MethodScanner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ public function setName($name)
*
* @param int $visibility T_PUBLIC | T_PRIVATE | T_PROTECTED
* @return self
* @throws \Zend\Code\Exception
* @throws \Zend\Code\Exception\InvalidArgumentException
*/
public function setVisibility($visibility)
{
Expand All @@ -303,7 +303,7 @@ public function setVisibility($visibility)
break;

default:
throw new Exception('Invalid visibility argument passed to setVisibility.');
throw new Exception\InvalidArgumentException('Invalid visibility argument passed to setVisibility.');
}

return $this;
Expand Down
11 changes: 11 additions & 0 deletions test/Scanner/MethodScannerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
namespace ZendTest\Code\Scanner;

use PHPUnit\Framework\TestCase;
use Zend\Code\Exception\InvalidArgumentException;
use Zend\Code\Scanner\FileScanner;
use Zend\Code\Scanner\MethodScanner;
use Zend\Code\Scanner\ParameterScanner;
use ZendTest\Code\TestAsset\AbstractClass;
use ZendTest\Code\TestAsset\BarClass;
Expand Down Expand Up @@ -110,4 +112,13 @@ public function testMethodScannerWorksWithSingleAbstractFunction()

self::assertTrue($method->isAbstract());
}

public function testMethodScannerThrowsExceptionWhenSettingInvalidVisibility()
{
$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('Invalid visibility argument passed to setVisibility.');

$methodScanner = new MethodScanner([]);
$methodScanner->setVisibility(-1);
}
}