Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

MySQL "ADD COLUMN ... AFTER ..." support #216

Merged
merged 7 commits into from
Feb 23, 2017

Conversation

nanawel
Copy link
Contributor

@nanawel nanawel commented Feb 10, 2017

ZF1 supports MySQL syntax allowing to add a column AFTER another one in an ALTER TABLE statement. ZF2 does not. This PR is intended to fix that.

@nanawel nanawel changed the base branch from master to develop February 10, 2017 12:10
@alextech
Copy link
Contributor

I want to say "needs a test" but looking at the decorator, there are no existing tests for it where you could have added it. Yet it must be done :) Can you please create an AlterTableDecoratorTest in the same place and same way CreateTableDecoratorTest and add your option in there? (I could assist if unsure how)

@nanawel
Copy link
Contributor Author

nanawel commented Feb 10, 2017

Sure, I'll add it to the PR.

Edit: seems like I included more commits than intended, I'll check that first.

@alextech
Copy link
Contributor

alextech commented Feb 10, 2017

Thank you :)

Edit: I am working under assumption that even though overly database specific modifications are usually rejected, since there is already a MySqlAlterTableDecorator, adding to it should not be a problem.

@nanawel
Copy link
Contributor Author

nanawel commented Feb 10, 2017

Yes, this is my assumption too.

@nanawel
Copy link
Contributor Author

nanawel commented Feb 10, 2017

New test class included, no error detected on PHPUnit on my instance.

@ezimuel ezimuel self-assigned this Feb 23, 2017
@ezimuel ezimuel merged commit db47b5a into zendframework:develop Feb 23, 2017
@ezimuel
Copy link
Contributor

ezimuel commented Feb 23, 2017

@nanawel thanks for your contribution!

@nanawel nanawel deleted the mysql-add-column-after-support branch December 27, 2017 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants