-
Notifications
You must be signed in to change notification settings - Fork 120
Conversation
Any ideas why the last build fails? Is it the issue with cache? Maybe we should add also |
@webimpress did you mean
you install https://github.com/doctrine/instantiator/releases/tag/1.1.0 which require PHP 7.1 thats the problem i mean with the |
@kokspflanze oh, you have right, thanks! The travis configuration here is so different (than others libraries) and probably we can improve it a lot... Definitely we need to add PHP 7.2 support in the library... I need to have another look on it. |
It is now handled by zendframework/zfbot
Added composer.lock file to the library.
This is not supported in old PHPUnit version. The argument should be added back when PHPUnit will be updated in the library.
The library still uses old coding standards so scripts in composer are now updated to use appropriate tools.
The version of PHPUnit is not detected correctly and it causes issues when rnning tests with lowest dependencies. This check is no needed because required version of PHPUnit in the library is version 4.0.0
- HYDRATOR_VERSION='^1.1' | ||
- SERVICE_MANAGER_VERSION='^2.7.5' | ||
- php: 7 | ||
- php: 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont miss to readd php 7 in the matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good point, I've missed that. Thanks. Done in c91b08b
Some tests are using prophecy which was not there on early PHPUnit 4.
Finally green ! |
It's too early to run builds on PHP 7.3-dev. Alpha has not been published yet.
I"m getting:
|
and nightly (7.3-dev) builds(removed as not even alpha has been published)