Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Enable use of MetadataFeature with TableIdentifier #392

Merged
merged 7 commits into from
Dec 31, 2019
Merged

Enable use of MetadataFeature with TableIdentifier #392

merged 7 commits into from
Dec 31, 2019

Conversation

jbelien
Copy link
Contributor

@jbelien jbelien commented Jul 30, 2019 •
edited
Loading

Fix #391

Provide a narrative description of what you are trying to accomplish:

@jbelien
Update MetadataFeature.php
5e0eda9 
Enable use of MetadataFeature with TableIdentifier

Fix #391
@jbelien jbelien mentioned this pull request Jul 30, 2019
Closed
2 tasks
michalbundyra
michalbundyra suggested changes Jul 30, 2019
View reviewed changes
Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbelien Thanks for your contribution.

We need unit tests to cover these changes.

@jbelien
Copy link
Contributor Author

jbelien commented Jul 30, 2019

@webimpress Sure, I probably can do that but never tried to add a test on a ZendFramework project.

Do I "just" have to add a new test that uses MetadataFeature with TableIdentifier in https://github.com/zendframework/zend-db/blob/master/test/unit/TableGateway/Feature/MetadataFeatureTest.php ?

@michalbundyra
Copy link
Member

@jbelien Cool! If you have any questions you can catch me on ZF slack

@jbelien
Copy link
Contributor Author

jbelien commented Jul 30, 2019 •
edited
Loading

@webimpress I apparently can't join the ZF Slack. When I try to login, it says that "I need to ask the workspace admin to invite me." (edit: fixed, invite via https://zendframework-slack.herokuapp.com/).

You didn't reply my question:

Do I "just" have to add a new test that uses MetadataFeature with TableIdentifier in TableGateway/Feature/MetadataFeatureTest.php ?

Thanks!

@michalbundyra
Copy link
Member

@jbelien
sorry, to join the slack you have to follow this link:
https://zendframework-slack.herokuapp.com

Do I "just" have to add a new test that uses MetadataFeature with TableIdentifier in https://github.com/zendframework/zend-db/blob/master/test/unit/TableGateway/Feature/MetadataFeatureTest.php ?

Yes, that's correct, as you are modifying MetadataFeature.php tests should be added in the corresponding test class.

michalbundyra
michalbundyra approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbelien it looks great now 👍 Thanks!

@jbelien
Copy link
Contributor Author

jbelien commented Jul 31, 2019

Thank you so much @webimpress for your help! ❤️

@michalbundyra michalbundyra added this to the 2.10.1 milestone Dec 31, 2019
@michalbundyra michalbundyra merged commit 3930525 into zendframework:master Dec 31, 2019
michalbundyra added a commit that referenced this pull request Dec 31, 2019
@michalbundyra
Merge pull request #392 from jbelien/patch-3
216599e 
Enable use of MetadataFeature with TableIdentifier
michalbundyra added a commit that referenced this pull request Dec 31, 2019
@michalbundyra
Adds CHANGELOG entry for #392
8879204
michalbundyra added a commit that referenced this pull request Dec 31, 2019
@michalbundyra
Merge branch 'hotfix/392' into develop
08dadd8 
Forward port #392
@michalbundyra
Copy link
Member

Thanks, @jbelien!

@jbelien jbelien deleted the patch-3 branch January 1, 2020 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michalbundyra michalbundyra michalbundyra approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.10.1
Development

Successfully merging this pull request may close these issues.

TableGateway used with TableIdentifier and MetadataFeature
2 participants
@jbelien @michalbundyra