This repository was archived by the owner on Jan 31, 2020. It is now read-only.
guzzle 6 compatibility #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
uhm.. unsure how this test failure relates to my PR |
|
the build failure also affects master .. and is indeed unrelated. |
|
@mtdowling can you give us a hint here how to best deal with these API changes? |
|
@rwos when you rebase on master the test failure should be gone. |
createRequest got removed
d961e4a to
51dc34e
Compare
|
Thanks @rwos |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createRequestgot removed in 6.This is obviously stupid, and might break again when Guzzle 7 comes out. Since there's now http://www.php-fig.org/psr/psr-7/ it would probably make sense to use that API and let the user inject a client instance, but yeah, that's hard to do while keeping BC... So, here's the easy "solution".