Thanks @Headd2k.

Is there any advantage of using vfs for those tests? I feel like adding dependency on that makes it more fragile. This is in the context of posix system (and fs) which allows chmods.

I was considering suggesting writing a different windows test case where you'd use windows ACL tools to modify permissions (instead of chmod)... the thing is, it might fail in case someone run the tests on i.e. FAT32 filesystem.

On the other hand, the vfs dependency might in future give false positives on real posix systems. The least we should do is make vfs tests run on windows only.

What are your thoughts?

hi @Thinkscape

thanks for your reply!

to be honest: i actually have no feelings pro or contra vfs. :)

i thought it might be the better way to test fs related stuff. i use vfs in my tests since a couple of years. the current directory related tests failed on my windows machine when chmod comes in place so i've set up vfs to test my changes.

to be clear: i just develop on windows but have all my production envionments on ubuntu.

you can delete this pr if you feel it might not be the right way for this project. i just had to fill a lazy afternoon. :)

regards

kai

I don't really want to delete anything :-)

What I'm considering is if we should use VFS on linux, where it's not really necessary.

@Thinkscape :)

the vfs is only a dependency for dev environments where you want to have the ability to run the tests. so i actually dont see this making the project "fragile" in any way. the tests using the real fs are currently still in place and executed during ci so it might be a "win" for both of us. :)

again: i have no big feelings about this pr. so it is really okay to refuse it. really! :)

maybe this little info page will help you on your decision: https://phpunit.de/manual/current/en/test-doubles.html#test-doubles.mocking-the-filesystem

regards

kai

Thanks!