This repository was archived by the owner on Jan 31, 2020. It is now read-only.
Redis auth parameter #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 :) |
|
👍 |
| $client->connect($this->host, $this->port); | ||
|
|
||
| if ($this->auth) { | ||
| $client->auth($this->auth); |
There was a problem hiding this comment.
Please add return value check. If the authentication fails, IMO the test should return a Failure.
There was a problem hiding this comment.
Added exception for authorization check, but it's overhead, because Redis when password is incorrect throws RedisException and then test will return Failure.
|
ping :) |
|
I'm going to merge it, but I'm not satisfied with how missing extensions are inconsistently handled in checks. Checks are not supposed to throw exceptions. Even though the default Runner here, and in ZFTool, will catch all exceptions and convert them into |
|
I'll take care of the cleanup. |
|
@Thinkscape, please make a new tag |
|
@Thinkscape, thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.