This repository was archived by the owner on Jan 31, 2020. It is now read-only.
Make compatible with sensiolabs/security-checker 5.0 #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c73c71c to
7021652
Compare
weierophinney
suggested changes
Nov 6, 2018
7021652 to
15854a3
Compare
|
Is possible to re-check this? Versions of sensiolabs/security-checker lower than |
15854a3 to
df1e93e
Compare
df1e93e to
db26fce
Compare
|
I changed the check to only work with sensiolabs/security-checker v5+ |
|
Any news on this one? |
weierophinney
added a commit
that referenced
this pull request
Jan 9, 2019
Make compatible with sensiolabs/security-checker 5.0
weierophinney
added a commit
that referenced
this pull request
Jan 9, 2019
weierophinney
added a commit
that referenced
this pull request
Jan 9, 2019
|
Thanks, @kbond; merged to develop for a 1.4.0 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
sensiolabs/security-checker5.x, theSensioLabs\Security\SecurityChecker::check()method returns a newSensioLabs\Security\Resultobject. This fix makes theSecurityAdvisorycheck compatible with this.