This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Upgrade league/oauth2-server to 7.x #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geerteltink
approved these changes
Nov 19, 2018
|
@sunspikes Thanks for this PR, I'll release a new version very soon! |
|
@sunspikes I'm changing composer.json to use: since the support of stateless has been merged in 7.3.0. |
|
@ezimuel Sure, thank you! |
|
This addition did inadvertently introduce a breaking change for some implementations. To fix this, I had to revert some of the stateless implementation. A side affect of this is that keys will be set on the response type for every request. It is a minor inconvenience but removes the BC while keeping the server stateless for Swoole. This fix should be removed in version 8. See here for further information. Apologies for any inconvenience caused! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the
thephpleague/oauth2-serverused by this library is does not work well with swoole server because its stateful. You can see data persisting between requests, in our case an access and refresh token get injected on the first successful password authentication and after that the same swoole worker serves a successful client credentials authentication and the response contains the refresh token on the first password authentication.This is now fixed in
7.3.0(thephpleague/oauth2-server#960) unfortunatelyzend-expressive-authentication-oauth2used 6.x. It would be awesome if we can switch the dependancy to 7.x which in fact is fairly simple, because there is only a small BC break and it is addressed by this PRAre you fixing a bug?
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.Are you creating a new feature?
developbranch, and submit against that branch.CHANGELOG.mdentry for the new feature.Is this related to quality assurance?
Is this related to documentation?