Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Add support for league/oauth2-server v8.0 #69

Merged
merged 8 commits into from
Dec 28, 2019
Merged

Add support for league/oauth2-server v8.0 #69

merged 8 commits into from
Dec 28, 2019

Conversation

thexpand
Copy link
Contributor

@thexpand thexpand commented Oct 7, 2019

This implements issue #66

@thexpand thexpand force-pushed the feature/league-oauth2-server-v8-support branch from d5ad5b6 to 6beb468 Compare October 7, 2019 20:30
michalbundyra
michalbundyra suggested changes Oct 7, 2019
View reviewed changes
Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thexpand Thanks for your effort. Could you please rebase and target develop?
I see it contains BC Breaks. Not possible without? If not, we will plan it for v2.0 release.

@thexpand thexpand force-pushed the feature/league-oauth2-server-v8-support branch from 6beb468 to eb9b05b Compare October 7, 2019 20:33
@thexpand
Copy link
Contributor Author

thexpand commented Oct 7, 2019 •
edited
Loading

@webimpress League's package changed their interfaces, so that's the reason we can't avoid it.

EDIT: Thanks for rebasing.

@michalbundyra michalbundyra changed the base branch from master to develop October 7, 2019 20:35
@michalbundyra michalbundyra added this to the 2.0.0 milestone Oct 7, 2019
@thexpand thexpand requested a review from michalbundyra October 7, 2019 20:53
@thexpand
Copy link
Contributor Author

@geerteltink @webimpress I made the changes you requested. Can you re-review?

@weierophinney weierophinney force-pushed the feature/league-oauth2-server-v8-support branch from 3d60356 to 7b0fa29 Compare December 28, 2019 20:48
weierophinney added a commit that referenced this pull request Dec 28, 2019
@weierophinney
docs: adds CHANGELOG entry for #69
b2bd348
@weierophinney weierophinney merged commit 7b0fa29 into zendframework:develop Dec 28, 2019
@weierophinney
Copy link
Member

Thanks, @thexpand!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@geerteltink geerteltink geerteltink left review comments

@michalbundyra michalbundyra Awaiting requested review from michalbundyra

Assignees
No one assigned
Labels
BC Break enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thexpand @weierophinney @michalbundyra @geerteltink