Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Implemented the check of fetched row, if isn't a array, throw exception #71

Closed
wants to merge 2 commits into from

Conversation

andersonluciano
Copy link

Bug fix of issue #70

Before the changes, if a tokenId previously generated by oAuth and delete from oauth_access_tokens, was submited, it throw a code 500 error, because of the row manipulation, was sent to a array_key_exists, but the fetch result was "false"

Now there's a check, if the row fetched isn't a array, throw a exception code 401

  • Are you fixing a bug?

    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.
  • Are you creating a new feature?

    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.
  • Is this related to quality assurance?

  • Is this related to documentation?

Copy link

@dennybrandes dennybrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalbundyra michalbundyra added this to the 1.2.1 milestone Dec 5, 2019
weierophinney added a commit that referenced this pull request Dec 28, 2019
weierophinney added a commit that referenced this pull request Dec 28, 2019
@weierophinney
Copy link
Member

Merged to master and develop; thanks, @andersonluciano !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants