Fixed problems with incorrect database schema in provided example. #72
Conversation
|
@sheridans Thanks in advance! |
There was a problem hiding this comment.
There are some extra points under "Are you fixing a bug?":
- Detail how the bug is invoked currently.
- Detail the original, incorrect behavior.
- Detail the new, expected behavior.
- Base your feature on the master branch, and submit against that branch.
- Add a regression test that demonstrates the bug, and proves the fix.
These bullet points are there to give us an inside on why you created the PR. Especially the first 3. I can imagine the current indexes might conflict and this PR fixes it, but some explanation would help.
EDIT: On a side node... the tests are failing as well as they need an update.
CHANGELOG.md
Outdated
| @@ -24,6 +24,28 @@ All notable changes to this project will be documented in this file, in reverse | |||
|
|
|||
| - Nothing. | |||
|
|
|||
| ## 1.2.1 - 2019-12-10 | |||
There was a problem hiding this comment.
Please don't add a release date. Leave that to the person merging your PR and creating a release.
There was a problem hiding this comment.
thank you, new to this :)
CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
|
|
||
| - Incorrect database schema in provide example. |
There was a problem hiding this comment.
A changelog entry should be like this:
- [#72](https://github.com/zendframework/zend-expressive-authentication-oauth2/pull/72)
fixes the incorrect example database schema.
There was a problem hiding this comment.
noted for next time :)
|
Problems with the provided example file... oauth_auth_codes.user_id is declared as INT, oauth_users has no relevant for relation oauth_auth_codes.client_id is declared as INT, oauth_clients has relevant field oauth_clients.user_id is declared as INT, again oauth_clients has no related field. |
The example mysql example has missing columns and incorrect column types.
47b750c to
64f9d4c
Compare
|
I've fixed the CHANGELOG entry and force-pushed back to your branch. |
fixed issues with missing values and iconsistent column types
Provide a narrative description of what you are trying to accomplish:
[ X] Are you fixing a bug?
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.Are you creating a new feature?
developbranch, and submit against that branch.CHANGELOG.mdentry for the new feature.Is this related to quality assurance?
The provided database schema is incorrect, has incosistent column types across tables. For example client_id and user_id being integer in one instance and varchar in another, multiple tables missing id files.
Is this related to documentation?