This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Ensure filter and validator chains receive default plugin managers #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the factory, the plugin managers used with the default filter and validator chains should be used with all newly created inputs, as these will have any custom services registered (vs. those that are in the initially created inputs, which are unconfigured). This means that: - For cases where the instance was pulled from the `InputFilterManager`, we need to inject the filter and validator chains with the plugin managers pulled from the default instances; if the chain does not exist, we clone the default instance. - For other instances, we need to simply clone the default filter and validator chains (which are empty, but have the configured filter and validator plugin managers).
Must conform to parent signature, even if `$context` optional argument is ignored.
The `EmailAddress` validator is using a deprecated constant, which causes errors in this test suite. As such, updated several tests to use a different validator to ensure we can test on 7.2.
weierophinney
added a commit
that referenced
this pull request
Dec 4, 2017
weierophinney
added a commit
that referenced
this pull request
Dec 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #155, When using the factory, particularly with the
InputFilterAbstractServiceFactory, the plugin managers used with the default filter and validator chains should be used with all newly created inputs, as these will have any custom services registered (vs. those that are in the initially created inputs, which are unconfigured).This means that:
InputFilterManager, we need to inject the filter and validator chains with the plugin managers pulled from the default instances; if the chain does not exist, we clone the default instance.This patch also contains two unrelated fixes, but they are included so that the test suite will actually pass under PHP 7.2:
CollectionInputFilter::isValidsignature to match that ofInputFilterInterface::isValid.EmailAddressvalidator; this validator uses constants deprecated in PHP 7.2, which raised errors during testing. These have each been updated to use the Digits validator instead, which is fully compatible.Fixes #155.