Deprecate EmptyContextInterface, InputInterface::setAllowEmpty & allowEmpty #26

Maks3w · 2015-08-20T11:29:29Z

Deprecate magic logic for auto attach a NonEmpty validator with breakChainOnFailure = true

Instead append NonEmpty validator when desired.

$input = new Zend\InputFilter\Input();
$input->setContinueIfEmpty(true);
$input->setAllowEmpty(true);
$input->getValidatorChain()->attach(new Zend\Validator\NotEmpty(), /* break chain on failure */ true);

Close #12

Maks3w · 2015-08-20T11:39:35Z

Since ZF 2.4 there are lot of bugs and headaches about the Required VS AllowEmpty VS ContinueIfEmpty matrix

This simplify the problem by removing the last two and forcing the user to attach the NotEmpty validator when he/she wants that behavior.

Maks3w · 2015-08-21T08:32:21Z

src/EmptyContextInterface.php

 interface EmptyContextInterface
 {
    /**
+     * @deprecated 2.5.5 Add Zend\Validator\NotEmpty validator to the ValidatorChain.


May we should describe setContinueIfEmpty(true) should be do too.

Maks3w · 2015-08-21T08:34:06Z

src/EmptyContextInterface.php

@@ -9,15 +9,22 @@

 namespace Zend\InputFilter;

+/**
+ * @deprecated 2.5.5 Add Zend\Validator\NotEmpty validator to the ValidatorChain.


Do we should deprecate this starting from 2.4.8?

weierophinney · 2015-08-22T14:18:09Z

Any delegation needs to happen in add new minor version; as such, it needs to be targeted at 2.6.0.

Maks3w · 2015-08-22T15:26:50Z

I propose to do this on next patch because I found this a thing to be done ASAP. Anyway the most important thing is if we all agree this should be removed

weierophinney · 2015-08-26T20:37:00Z

Any deprecations MUST happen at a new minor release. After we get the other issues ironed out, we can do a 2.6.0 release with these changes.

Maks3w · 2015-08-27T11:17:20Z

Rebased on top of develop

Maks3w · 2015-08-28T07:35:40Z

Anyway I think deprecations should be backport to the lowest version for early adoptions of workarounds.

As soon as the developer avoid deprecated features as soon he/she will upgrade to major versions with less effort.

Maks3w · 2015-09-01T18:37:09Z

I think we have two classes of deprecatations.

New features which make obsolete old one. This should be deprecated in a new minor because includes a new feature.
Removal of code without new feature. This could be deprecated at any moment because there is no new code related to it.

weierophinney · 2015-09-01T18:46:56Z

CHANGELOG.md

@@ -2,6 +2,32 @@

 All notable changes to this project will be documented in this file, in reverse chronological order by release.

+## 2.6.0 - TBD


I'm confused at this point. In IRC, you're indicating this should be merged against the LTS release as well; to my mind, that's saying it should be part of the 2.4 and 2.5 series, and not require a new version. If this is truly backwards compatible, I'm inclined to do so, as it gives the cleanest path forwards for existing users to upgrade.

However, here, you're indicating the next new minor version, 2.6.0. I'm not sure if this is due to the feedback I provided previously, or if this was what you originally intended. However, it's contrary to being submitted against the master branch, which targets 2.5.

So, confusion all around on my part.

Can you clarify, please?

@weierophinney said: Any delegation needs to happen in add new minor version; as such, it needs to be targeted at 2.6.0.

Maks3w · 2015-09-01T19:09:57Z

Ready for 2.4.8 LTS

Deprecate magic logic for auto attach a NonEmpty validator with breakChainOnFailure = true Instead append NonEmpty validator when desired. ```php $input = new Zend\InputFilter\Input(); $input->setContinueIfEmpty(true); $input->setAllowEmpty(true); $input->getValidatorChain()->attach(new Zend\Validator\NotEmpty(), /* break chain on failure */ true); ```

…dator-logic Deprecate EmptyContextInterface, InputInterface::setAllowEmpty & allowEmpty

Close #26

Forward port #26

Includes these changes: - [14: NotEmpty validator doesn't override the required attribute](zendframework#14) - [16: BC in validators context value](zendframework#16) - [24: Fix loop validation input context is mutable](zendframework#24) - [25: Fix missing optional fields should not be validated](zendframework#25) - [26: Deprecate magic logic for auto attaching a NonEmpty validator with breakChainOnFailure = true](zendframework#26) - [31: Update the InputFilterInterface::add docblock to match existing, shipped implementations](zendframework#31) - [32: Promote HHVM](zendframework#32) - [36: Fix docblocks declared as regular comment block](zendframework#36) - [40: Remove test about Input setters permutation](zendframework#40) - [41: Refactor tests for group 7448 as a data set matrix](zendframework#41) - [42: Consolidate InputFilterPluginManager tests](zendframework#42) - [43: Consolidate Factory tests + Fixes](zendframework#43) - [44: Consolidate of InputInterface::merge and Fix unsafe merge](zendframework#44) - [45: When merge Inputs don't merge values if source does not have one.](zendframework#45) - [46: Expand test matrix with nonempty value scenarios](zendframework#46) - [47: Feature/minor test improvements](zendframework#47) - [48: Empty values + Allow Empty + Not continue if empty is always true](zendframework#48) - [49: Add tests for exceptions and improve some messages](zendframework#49) - [50: Optional fields without value should be valid ](zendframework#50) - [51: Optional input without value are valid](zendframework#51) - [52: Fix merge two inputs without value, result 'has value' flag should be false](zendframework#52) - [56: Hotfix/minor changes](zendframework#56) - [57: Consolidate tests for InputFilterInterface](zendframework#57) - [61: Provide NotEmpty::IS&zendframework#95;EMPTY validation message for required input](zendframework#61) - [63: Ensure custom error messages are used for required missing inputs](zendframework#63) - [64: Feature/test cleanup](zendframework#64)

Includes these changes: - [14: NotEmpty validator doesn't override the required attribute](zendframework#14) - [16: BC in validators context value](zendframework#16) - [24: Fix loop validation input context is mutable](zendframework#24) - [25: Fix missing optional fields should not be validated](zendframework#25) - [26: Deprecate magic logic for auto attaching a NonEmpty validator with breakChainOnFailure = true](zendframework#26) - [31: Update the InputFilterInterface::add docblock to match existing, shipped implementations](zendframework#31) - [36: Fix docblocks declared as regular comment block](zendframework#36) - [40: Remove test about Input setters permutation](zendframework#40) - [41: Refactor tests for group 7448 as a data set matrix](zendframework#41) - [42: Consolidate InputFilterPluginManager tests](zendframework#42) - [43: Consolidate Factory tests + Fixes](zendframework#43) - [44: Consolidate of InputInterface::merge and Fix unsafe merge](zendframework#44) - [45: When merge Inputs don't merge values if source does not have one.](zendframework#45) - [46: Expand test matrix with nonempty value scenarios](zendframework#46) - [47: Feature/minor test improvements](zendframework#47) - [48: Empty values + Allow Empty + Not continue if empty is always true](zendframework#48) - [49: Add tests for exceptions and improve some messages](zendframework#49) - [50: Optional fields without value should be valid ](zendframework#50) - [51: Optional input without value are valid](zendframework#51) - [52: Fix merge two inputs without value, result 'has value' flag should be false](zendframework#52) - [56: Hotfix/minor changes](zendframework#56) - [57: Consolidate tests for InputFilterInterface](zendframework#57) - [61: Provide NotEmpty::IS&zendframework#95;EMPTY validation message for required input](zendframework#61) - [63: Ensure custom error messages are used for required missing inputs](zendframework#63) - [64: Feature/test cleanup](zendframework#64)

Includes these changes: - [14: NotEmpty validator doesn't override the required attribute](zendframework/zend-inputfilter#14) - [16: BC in validators context value](zendframework/zend-inputfilter#16) - [24: Fix loop validation input context is mutable](zendframework/zend-inputfilter#24) - [25: Fix missing optional fields should not be validated](zendframework/zend-inputfilter#25) - [26: Deprecate magic logic for auto attaching a NonEmpty validator with breakChainOnFailure = true](zendframework/zend-inputfilter#26) - [31: Update the InputFilterInterface::add docblock to match existing, shipped implementations](zendframework/zend-inputfilter#31) - [36: Fix docblocks declared as regular comment block](zendframework/zend-inputfilter#36) - [40: Remove test about Input setters permutation](zendframework/zend-inputfilter#40) - [41: Refactor tests for group 7448 as a data set matrix](zendframework/zend-inputfilter#41) - [42: Consolidate InputFilterPluginManager tests](zendframework/zend-inputfilter#42) - [43: Consolidate Factory tests + Fixes](zendframework/zend-inputfilter#43) - [44: Consolidate of InputInterface::merge and Fix unsafe merge](zendframework/zend-inputfilter#44) - [45: When merge Inputs don't merge values if source does not have one.](zendframework/zend-inputfilter#45) - [46: Expand test matrix with nonempty value scenarios](zendframework/zend-inputfilter#46) - [47: Feature/minor test improvements](zendframework/zend-inputfilter#47) - [48: Empty values + Allow Empty + Not continue if empty is always true](zendframework/zend-inputfilter#48) - [49: Add tests for exceptions and improve some messages](zendframework/zend-inputfilter#49) - [50: Optional fields without value should be valid ](zendframework/zend-inputfilter#50) - [51: Optional input without value are valid](zendframework/zend-inputfilter#51) - [52: Fix merge two inputs without value, result 'has value' flag should be false](zendframework/zend-inputfilter#52) - [56: Hotfix/minor changes](zendframework/zend-inputfilter#56) - [57: Consolidate tests for InputFilterInterface](zendframework/zend-inputfilter#57) - [61: Provide NotEmpty::IS_EMPTY validation message for required input](zendframework/zend-inputfilter#61) - [63: Ensure custom error messages are used for required missing inputs](zendframework/zend-inputfilter#63) - [64: Feature/test cleanup](zendframework/zend-inputfilter#64)

Maks3w force-pushed the feature/deprectate-AddNotEmptyValidator-logic branch from 25011f8 to 4f7a0a2 Compare August 20, 2015 11:33

Maks3w reviewed Aug 21, 2015
View reviewed changes

Maks3w added this to the 2.4.8 milestone Aug 21, 2015

Maks3w added enhancement question labels Aug 21, 2015

Maks3w reviewed Aug 21, 2015
View reviewed changes

Maks3w assigned weierophinney Aug 24, 2015

Maks3w added the awaiting maintainer response label Aug 24, 2015

weierophinney modified the milestones: 2.6.0, 2.4.8 Aug 26, 2015

weierophinney removed the awaiting maintainer response label Aug 26, 2015

Maks3w force-pushed the feature/deprectate-AddNotEmptyValidator-logic branch from 4f7a0a2 to 4b40e52 Compare August 27, 2015 11:13

Maks3w added awaiting maintainer response and removed question labels Aug 27, 2015

weierophinney reviewed Sep 1, 2015
View reviewed changes

Maks3w force-pushed the feature/deprectate-AddNotEmptyValidator-logic branch from 4b40e52 to 62c4d0c Compare September 1, 2015 19:09

Maks3w modified the milestones: 2.4.8, 2.6.0 Sep 1, 2015

Maks3w force-pushed the feature/deprectate-AddNotEmptyValidator-logic branch from 62c4d0c to fe57157 Compare September 1, 2015 19:12

weierophinney removed the awaiting maintainer response label Sep 1, 2015

weierophinney merged commit fe57157 into zendframework:master Sep 1, 2015

weierophinney added a commit that referenced this pull request Sep 1, 2015

Merge pull request #26 from Maks3w/feature/deprectate-AddNotEmptyVali…

e2c1ef3

…dator-logic Deprecate EmptyContextInterface, InputInterface::setAllowEmpty & allowEmpty

weierophinney added a commit that referenced this pull request Sep 1, 2015

Merge branch 'hotfix/26'

3cfbcda

Close #26

weierophinney added a commit that referenced this pull request Sep 1, 2015

Merge branch 'hotfix/26' into develop

d6316f3

Forward port #26

Maks3w deleted the feature/deprectate-AddNotEmptyValidator-logic branch September 1, 2015 21:37

dennybrandes mentioned this pull request Jul 15, 2019

Empty validation message for file input when sent array for file input #184

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate EmptyContextInterface, InputInterface::setAllowEmpty & allowEmpty #26

Deprecate EmptyContextInterface, InputInterface::setAllowEmpty & allowEmpty #26

Maks3w commented Aug 20, 2015

Maks3w commented Aug 20, 2015

Maks3w Aug 21, 2015

Maks3w Aug 21, 2015

weierophinney commented Aug 22, 2015

Maks3w commented Aug 22, 2015

weierophinney commented Aug 26, 2015

Maks3w commented Aug 27, 2015

Maks3w commented Aug 28, 2015

Maks3w commented Sep 1, 2015

weierophinney Sep 1, 2015

Maks3w Sep 1, 2015

Maks3w commented Sep 1, 2015

		@@ -2,6 +2,32 @@

		All notable changes to this project will be documented in this file, in reverse chronological order by release.

		## 2.6.0 - TBD

Deprecate EmptyContextInterface, InputInterface::setAllowEmpty & allowEmpty #26

Deprecate EmptyContextInterface, InputInterface::setAllowEmpty & allowEmpty #26

Conversation

Maks3w commented Aug 20, 2015

Maks3w commented Aug 20, 2015

Maks3w Aug 21, 2015

Choose a reason for hiding this comment

Maks3w Aug 21, 2015

Choose a reason for hiding this comment

weierophinney commented Aug 22, 2015

Maks3w commented Aug 22, 2015

weierophinney commented Aug 26, 2015

Maks3w commented Aug 27, 2015

Maks3w commented Aug 28, 2015

Maks3w commented Sep 1, 2015

weierophinney Sep 1, 2015

Choose a reason for hiding this comment

Maks3w Sep 1, 2015

Choose a reason for hiding this comment

Maks3w commented Sep 1, 2015