This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Not set default required error message always #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip if a previous one was set
| { | ||
| $input = $this->input; | ||
| $input->setRequired(true); | ||
| $input->setErrorMessage('fooErrorMessage'); |
There was a problem hiding this comment.
This isn't what #28 was getting at.
Prior to 2.4, a required input that was provided an empty value would return [ 'isEmpty' => "Value is required and can't be empty"] for the messages; that's what the reporter wants to happen again.
I'll work on this using your patch as a start, and submit an alternate PR.
weierophinney
added a commit
to weierophinney/zend-inputfilter
that referenced
this pull request
Sep 3, 2015
…message-if-was-set Not set default required error message always
weierophinney
added a commit
to weierophinney/zend-inputfilter
that referenced
this pull request
Sep 3, 2015
- `getMessages()` is expected to return the `NotEmpty::IS_EMPTY` message template.
|
Closing in favor of #61. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip if a previous one was set
Partial fix for #28.
This does not allow to translate automatically with multiple localizations.