This repository was archived by the owner on Jan 30, 2020. It is now read-only.
BaseInputFilter::populate() calls resetValue() for missing arrayinputs #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -513,7 +513,7 @@ protected function populate() | |||
| } | |||
|
|
|||
| if ($input instanceof ArrayInput) { | |||
| $input->setValue([]); | |||
| $input->resetValue(); | |||
There was a problem hiding this comment.
The whole if can be removed because ArrayInput is a child of Input
There was a problem hiding this comment.
Good catch, thank you.
ArrayInput is a child of Input so no need for an additional check of ArrayInput instance.
Maks3w
added a commit
that referenced
this pull request
Oct 8, 2015
ArrayInput specific logic branch its not longer present and current Input tests are enough
Maks3w
added a commit
that referenced
this pull request
Oct 8, 2015
Maks3w
added a commit
that referenced
this pull request
Oct 8, 2015
|
Merged for next bugfix release. I don't consider this need to be backported to LTS /cc @weierophinney |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasValuereturns true for ArrayInputs whether or not a value was provided viaInputFilter::setData(). This can't be the expected behavior of this function.However, i had to refactor the existing test
BaseInputFilterTest::testPopulateSupportsArrayInputEvenIfDataMissing. I don't know the implications regarding BC because neither the docblock nor the commit message provided a useful use-case for this test-method.Feedback is very welcome.
Thank you for considering my pull request.