Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

fix for PHP 7.2, 'Object' is a reserved keyword #33

Merged
merged 1 commit into from
Jan 4, 2018
Merged

fix for PHP 7.2, 'Object' is a reserved keyword #33

merged 1 commit into from
Jan 4, 2018

Conversation

remicollet
Copy link
Contributor

From Fedora QA:
https://apps.fedoraproject.org/koschei/package/php-zendframework-zend-json?collection=f28

PHPUnit 5.7.23 by Sebastian Bergmann and contributors.
Runtime:       PHP 7.2.0RC4
Configuration: /builddir/build/BUILD/zend-json-f42a1588e75c2a3e338cd94c37906231e616daab/phpunit.xml.dist
..................................PHP Fatal error:  Cannot use 'Object' as class name as it is reserved in /builddir/build/BUILD/zend-json-f42a1588e75c2a3e338cd94c37906231e616daab/test/TestAsset/Object.php on line 13

@froschdesign froschdesign mentioned this pull request Oct 24, 2017
Closed
@michalbundyra michalbundyra mentioned this pull request Nov 3, 2017
Merged
@weierophinney weierophinney merged commit a17d2a6 into zendframework:master Jan 4, 2018
weierophinney added a commit that referenced this pull request Jan 4, 2018
@weierophinney
Merge pull request #33 from remicollet/issue-php72
31fb573 
fix for PHP 7.2, 'Object' is a reserved keyword
weierophinney added a commit that referenced this pull request Jan 4, 2018
@weierophinney
Merge branch 'hotfix/qa-tools'
c7eecaa 
Close #24
Close #26
Close #28
Close #33
weierophinney added a commit that referenced this pull request Jan 4, 2018
@weierophinney
Merge branch 'hotfix/qa-tools' into develop
e85bd6d 
Forward port #24
Forward port #26
Forward port #28
Forward port #33
@weierophinney
Copy link
Member

Thanks, @remicollet

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remicollet @weierophinney