Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Fix ZendTest\Ldap\ConnectTest::testUnknownHostConnect #31 #40

Merged
merged 2 commits into from
Apr 21, 2016
Merged

Fix ZendTest\Ldap\ConnectTest::testUnknownHostConnect #31 #40

merged 2 commits into from
Apr 21, 2016

Conversation

yeiniel
Copy link
Contributor

@yeiniel yeiniel commented Feb 23, 2016

Test using a list of possible messages.

@heiglandreas
Copy link
Member

You do know that you don't have to open a new PR when you make changes? It is sufficient to push to the existing branch.

@yeiniel
Copy link
Contributor Author

yeiniel commented Feb 23, 2016

Sorry, lack of experience with github. More of a bitbucket user.

@heiglandreas
Copy link
Member

No Problem. Should be the same on bitbucket though 😉

@yeiniel
Copy link
Contributor Author

yeiniel commented Feb 23, 2016

I guess it is.

$alternatives = ['Can\'t contact LDAP server',
'Failed to connect to LDAP server'];
$message = $zle->getMessage();
$found = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this line

@heiglandreas heiglandreas added this to the 2.7.0 milestone Apr 21, 2016
@heiglandreas heiglandreas self-assigned this Apr 21, 2016
@heiglandreas heiglandreas merged commit f83a9c4 into zendframework:master Apr 21, 2016
heiglandreas added a commit that referenced this pull request Apr 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants