This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Fixes issue with sorting in PHP7 #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit alters the sort-algorithm used for testing which before was based on the position of the entry in the array and is now solely based on the value itself. Due to changes in PHP7 sorting based on the key of the value was not working in PHP7 as it was in PHP5 so there was need for a change. Nowe the values are sorted by the number of "1" in the binary representation of the value. If that is equals the natural sorting algorithm is used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR alters the sort-algorithm used for testing which before was based on the position of the entry in the array and is now solely based on the value itself.
Due to changes in PHP7 sorting based on the key of the value was not working in PHP7 as it was in PHP5 so there was need for a change.
Now the values are sorted by the number of "1" in the binary representation of the value. If that is equals the natural sorting algorithm is used.
This also fixes #32