This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Added an ldap_mod_del and ldap_mod_add functionality. #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a way to delete or add one or more attributes to the specified dn. This PR issue zendframework#5
|
Thanks for your contribution! I'll review it as soon as I'm back from holiday (being sunday). |
|
Yep, hope it will be fine. Enjoy vacation 👍 |
|
@martinjinda there is already a method Only the add method is missing or did i overseen something? |
|
@ThaDafinser You didn't, but I did. So that's great. Plus I didn't control input from user in the entry at all. |
- addAttr() renamed to addAttributes() and it was added check of user input. - delAttr() was duplicate of deleteAttributes(), it was removed.
|
@martinjinda Thanks for your contribution. Can you please also add a test for the method? |
|
Damned Typo in a commit-message... |
|
@martinjinda Any news on this PR? I'D love to add it to the lib but I'd need some tests for that… |
|
@heiglandreas Thanks for remind me. Will take a look. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to delete or add one or more attributes to the
specified dn.
This PR issue #5