Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Added a ldap mod replace #73

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Added a ldap mod replace #73

merged 2 commits into from
Jul 5, 2018

Conversation

glimac
Copy link

@glimac glimac commented Oct 9, 2017

I would like to add my contribution to zend-ldap by adding an updateAttributes () method.

@heiglandreas heiglandreas changed the base branch from master to develop October 9, 2017 17:59
@heiglandreas
Copy link
Member

heiglandreas commented Oct 9, 2017 •
edited
Loading

Hey @glimac. Thanks for your PR.

As I'm currently on holiday I will not be able to review the PR completely. But from a first glance I'Ve seen that there are no tests. Would you mind fixing that?

And you might want to have a look at #68 that implements the same functionality…

@glimac
Copy link
Author

glimac commented Oct 9, 2017

Hi @heiglandreas, thank you for your appreciation and performed the tests for this functionality.

@glimac glimac changed the title Feature/ldap mod replace Added a ldap mod replace Oct 9, 2017
@mbaynton mbaynton mentioned this pull request Nov 2, 2017
Open
@heiglandreas heiglandreas merged commit 674ab67 into zendframework:develop Jul 5, 2018
heiglandreas added a commit that referenced this pull request Jul 5, 2018
@heiglandreas
Merge pull request #73 from glimac/feature/ldap_mod_replace
7c81442 
Added a ldap mod replace
heiglandreas added a commit that referenced this pull request Jul 5, 2018
@heiglandreas
Merge branch 'feature/73' into develop
5adb684 
Closes #73
Closes #68
Closes #67
@heiglandreas heiglandreas mentioned this pull request Jul 5, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glimac @heiglandreas