This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Unittests failing #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a change in the zend-session library; @mwillbanks - can you look into this please, as I know you've been merging zend-session changes recently... |
|
Reassigned back to @weierophinney as this was due to zendframework/zend-inputfilter#7 |
zendframework/zend-inputfilter#7 introduced a minor change in how required elements are handled in specific cases, and this results in a change in how the "Value is required" validation message is injected into validation failures. This patch makes the test more robust in searching for that message.
|
The issue is due to how the "required" validation failure message is injected after zendframework/zend-inputfilter#7; the patch I've introduced just updates the test to be more robust in how it finds that message in the returned validation failure message list. |
weierophinney
added a commit
that referenced
this pull request
Aug 11, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just cloned this repo and unittests fails for both master and 2.5: