This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Ensure proper PHPDoc #234
Merged
Ensure proper PHPDoc #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ller` Since those methods got already replaced by controller plugins, we can safely remove the method declaration and let the `AbstractController::__call` method handle the plugin calls.
- Fixed `return` for `AbstractActionController::indexAction` - Added exception description to `AbstractActionController::onDispatch`
weierophinney
suggested changes
Apr 27, 2017
| * | ||
| * {@inheritDoc} | ||
| */ | ||
| protected function createHttpNotFoundModel(HttpResponse $response) |
There was a problem hiding this comment.
While these methods should have been removed for the 3.0 release, they were not, and, as such, doing so now is a backwards compatibility break. Please create a separate PR for these removals which we can tag for the 4.0 release (which will target PHP 7.1).
Thanks!
There was a problem hiding this comment.
Actually they were removed in #99
I will revert the commit on this for release-2.7 tho.
…onController`" This reverts commit 94cc178.
weierophinney
added a commit
that referenced
this pull request
May 1, 2017
Ensure proper PHPDoc and remove deprecated methods
weierophinney
added a commit
that referenced
this pull request
May 1, 2017
weierophinney
added a commit
that referenced
this pull request
May 1, 2017
|
Thanks, @boesing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since always(?), the
AbstractActionController::notFoundActionand theAbstractActionController::indexActionreturnViewModel/ConsoleModelinstead ofarray.Aswell, I've removed deprecated methods which are already replaced by controller plugins aswell.