This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Fix 'Call to a member function hasChildren() on boolean' #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This seems to occur when the DefaultRenderingStrategy tries to render a result that is not an instance of Zend\View\Model\ModelInterface, in my case the result was a boolean true. - I'm checking for ModelInterface rather than ConsoleModel as the render method seems to work with any ModelInterface, not just ConsoleModel
| @@ -42,7 +43,7 @@ public function render(MvcEvent $e) | |||
| // marshal arguments | |||
| $response = $e->getResponse(); | |||
|
|
|||
| if (empty($result)) { | |||
| if (empty($result) || !($result instanceof ModelInterface)) { | |||
There was a problem hiding this comment.
You can simply remove the empty() call
There was a problem hiding this comment.
Except this comment, all of your other comments relate to the existing test code that I copied. So I'll apply your suggestions to both tests - I was just following what was already there :)
|
👍 (except nitpicking) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a result that is not an instance of Zend\View\Model\ModelInterface, in
my case the result was a boolean true.
method seems to work with any ModelInterface, not just ConsoleModel