This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Try to use AuthenticationServiceInterface for the Identity plugin #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, IdentityFactory asks the ServiceManager to find AuthenticationService (the class). It may be useful to also try to find service named AuthenticationServiceInterface if the previous one was not found, especially since projects may prefer to typehint to interface rather than to class. Finally, AuthenticationServiceInterface defines both methods used by the Identity plugin: hasIdentity and getIdentity.
In particular, a test for the scenario described in #9, but also all other behaviors.
weierophinney
added a commit
that referenced
this pull request
Apr 30, 2018
weierophinney
added a commit
that referenced
this pull request
Apr 30, 2018
|
Thanks, @gscscnd! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
IdentityFactoryasks theServiceManagerto findAuthenticationService(the class). It may be useful to also try to find service namedAuthenticationServiceInterfaceif the previous one was not found, especially since projects may prefer to typehint to interface rather than to class. Finally,AuthenticationServiceInterfacedefines both methods used by theIdentityplugin:hasIdentityandgetIdentity.