This shouldn't be changed

I'm not sure what else can be done. These things end up in EventManager::triggerListeners(), which does a $listener($event), not a $listener->isValid() or a call_user_func($listener). Suggestions?

Previous format was correct. Implementators was using [new $validator($data), 'isValid'] which is callable too

Well, I'll be. Right you are. Must've been something else in there breaking all the tests for validators then.

I would like to see an alternative to this using the public API.

@Maks3w - for tests, I've been using a similar pattern in other components.
The getListeners and getEvents methods only really existed for testing
purposes, which is why they were removed during the refactor. The downside
is, of course, that testing now often needs to rely on reflection to
validate expectations. My point is: there isn't a way currently to verify
using the public API at this point other than triggering the event, which
often has side effects. Reflection should be fine here.
On Oct 25, 2015 2:09 PM, "Maks3w" notifications@github.com wrote:

In test/Service/SessionManagerFactoryTest.php
#8 (comment)
:

     $manager->start();

•    $this->assertEquals(1, $manager->getValidatorChain()->getListeners('session.validate')->count());
  

•    $chain = $manager->getValidatorChain();
  

•    $r = new \ReflectionMethod($chain, 'getListenersByEventName');
  

I would like to see an alternative to this using the public API.

—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/zend-session/pull/8/files#r42948778.

And spy EventManagerInterface::attach was called?

@Maks3w Correct. That's what the reflection calls are doing, essentially; verifying that the factory attached listeners for specific event names.

Note the callable typehint make impossible to be array

Not true; arrays can be php callables. [$instance, $methodName] validates
as callable when:

• $instance is an object where $methodName is a publicly callable
  method, OR
• $instance is an object or class name and $methodName is a publicly
  callable static method.
  On Oct 25, 2015 2:30 PM, "Maks3w" notifications@github.com wrote:

In src/ValidatorChain.php
#8 (comment)
:

  * @param  callable $callback
  * @param  int $priority
  * @return \Zend\Stdlib\CallbackHandler
  */

• public function attach($event, $callback = null, $priority = 1)
• public function attach($eventName, callable $callback, $priority = 1)

Note the callable typehint make impossible to be array

—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/zend-session/pull/8/files#r42949108.

container-interop should be added as a dev dependency. Yes, the SM depends on it as well, but you're explicitly referencing it in code here, which makes it another dependency.