added php 7.2 && nightly in travis #135
Conversation
The php renderer was only catching Exception - PHP 7 changed how error are reported http://php.net/manual/en/language.errors.php7.php
removed hhvm in travis
.travis.yml
Outdated
| - php: 7.2 | ||
| env: | ||
| - DEPS=latest | ||
| - php: nightly |
There was a problem hiding this comment.
Not sure if we need both - PHP 7.2 and nightly.
There was a problem hiding this comment.
nightly is php7.3
There was a problem hiding this comment.
Great, thanks! We should then update maintainers template probably ;-)
…en the doctype is Xhtml
…l isValid() in HeadMeta::setCharset() before set()
|
LGTM 👍 |
.travis.yml
Outdated
| @@ -45,6 +30,8 @@ matrix: | |||
| - php: 7 | |||
| env: | |||
| - DEPS=locked | |||
| - CHECK_CS=true | |||
There was a problem hiding this comment.
Expected variable is CS_CHECK, please see line 84
.travis.yml
Outdated
| irc: "irc.freenode.org#zftalk.dev" | ||
| email: false | ||
| - php: 7.2 | ||
| - php: nightly |
There was a problem hiding this comment.
Too early... Can be removed, see: zendframework/zend-expressive-hal#9
.travis.yml
Outdated
| notifications: | ||
| irc: "irc.freenode.org#zftalk.dev" | ||
| email: false | ||
| - php: 7.2 |
There was a problem hiding this comment.
Now shouldn't be allowed to fail, right? :)
There was a problem hiding this comment.
yes, its a pr from august 2017
i dont want to update it each month and wait more and more
|
Let's do the following:
|
remove php 72 from allow fail
|
nightly was already removed with 94e9ecc |
…k-navigation Added navigation helpers in DocBlock of navigation proxy helper for code completion
…lper has translator already
spelling fixes
Closing parentheses of the attach method parameters
PHP 7 - Php Renderer - Catching Error - Bug fix
added php 7.2 && nightly in travis
zend-session 2.8.1 is the first that offers PHP 7.2 compabitibility, and is thus the first version zend-view can rely on if it wants to provide 7.2 support. This is a development dependency, so no minor bump is necessary.
|
|
||
| before_install: | ||
| - if [[ $TEST_COVERAGE != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi | ||
| - composer self-update | ||
| - travis_retry composer self-update |
|
Thanks, @kokspflanze; merged to develop for release with 2.10.0. |
added php 7.2 && nightly in travis
removed hhvm in travis