Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

remove unneeded check for services has("ControllerManager") at ForwardFactory #5437

Conversation

samsonasik
Copy link
Contributor

based on @Ocramius suggestion on #4962

@Ocramius
Copy link
Member

Ocramius commented Nov 7, 2013

👍 - an exception is caused anyways :)

By the way, you have a typo in the commit message.

@samsonasik samsonasik closed this Nov 7, 2013
@samsonasik samsonasik reopened this Nov 7, 2013
@samsonasik
Copy link
Contributor Author

@Ocramius what the typo ? :D

@Ocramius
Copy link
Member

Ocramius commented Nov 7, 2013

ControlerManager ? :-)

@samsonasik
Copy link
Contributor Author

@Ocramius done . amended ;)

@bakura10
Copy link
Contributor

bakura10 commented Nov 7, 2013

I like those changes 👍 .

@weierophinney
Copy link
Member

Sorry, I don't see how this would be beneficial at all. That exception was added precisely because the exception raised by the ServiceManager did not provide appropriate context -- developers were not sure why the service manager was being called in the first place, nor where, and were looking in the wrong place in the code to debug. By adding this test, we were able to provide a context, which assists developers in identifying root cause of issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants