First contrib. and commit. #9
Conversation
Altered ZendTest\Authentication to test for new exceptions and messages
Moved _files in tests/Zend/Acl to TestAsset
|
Almost, but not quite :) Here are some suggestions. First, you'll need to create a new branch to work out of based on milestones/exceptions, perhaps you might call it milestones/exceptions-dom, or something to that effect. That branch will contain your Dom based work. As for the code, the main Exception should be an interface. You should also create an Exception/ namespace and put the RuntimeException in that namespace. The RuntimeException should extend the SPL \RuntimeException class and implement the \Zend\Dom\Exception interface. That should do it, you can catch me in #zftalk.dev to discuss how to get this in a place that can be merged in. |
|
Thanks for the reply. I have made the ammendments you suggested. Sorry to say I only scan read the post you linked to the other day on zfdev so im gonna read that properly tonight :) I am using Git Bash for windows with Github as my remote repo. I currently have all the changes in a separate branch of my master zf2 branch (forked from zendFramework). Should I commit my changes to milestones/exceptions branch on Github? If so how do I commit to a branch on Github using Git Bash, cant seem to get do it? Thanks for all your help, Im sure I am nearly there :) Also, I followed the same approach adopted with the Zend/Acl Exception changes, which I think I read you mentioned was OK to do so i a blog post? |
…lection Merging Zend\Http request header collection
…eature/cache_beta2 Feature/cache beta2
…eature/cache_beta2 Feature/cache beta2
…/http-foundation-header-collection Merging Zend\Http request header collection
…eature/cache_beta2 Feature/cache beta2
…eature/cache_beta2 Feature/cache beta2
- [#9](zendframework/zend-form#9) Correct typo in aria attributes' names There should not be a dash before “by”: - http://www.w3.org/TR/wai-aria/states_and_properties#aria-labelledby - http://www.w3.org/TR/wai-aria/states_and_properties#aria-describedby This fixes a typo I introduced in #5989. - [#12](zendframework/zend-form#12) Deprecated AllowEmpty and ContinueIfEmpty annotations
Hi,
Ive added new exception support to \Zend\Dom.
This is my very first commit so i may have got things wrong :). I am aware I probably should have created a branch but I am just getting used to Git (git Bash) as I have not used it before so for this instance I have commited to my master branch so I hope this is OK.
The changes I made were very small, I just created a new RuntimeException class, updated Query.php to use this class and updated the comments. Ralph Schindler did say that I would also need to create an InvalidArgument class but couldnt quite see where this would easily go.
If anything else needs to be done to this class or if I have done anything wrong please let me know.
Thanks