Update zphysics #761
Merged
Update zphysics #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
b323848 to
aa75bc4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the zphysics library dependency, requiring significant code changes to adapt to the new API. The update involves modernizing the interface patterns from manual vtable management to a more structured approach using embedded interface objects and proper method visibility.
- Migrates from manual vtable and
usingnamespacepatterns to embedded interface objects with.init()calls - Updates calling conventions from
.Cto.cthroughout the codebase - Replaces
std.math.maxIntsentinel values with proper.invalidenum values for body IDs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| samples/physics_test_wgpu/src/physics_test_wgpu.zig | Updates interface implementations and shape creation methods for zphysics API changes |
| samples/monolith/src/monolith.zig | Comprehensive migration including interface updates, body ID handling, and debug renderer vtable changes |
| libs/zphysics | Updates submodule reference to newer zphysics version |
Comments suppressed due to low confidence (1)
samples/monolith/src/monolith.zig:252
- [nitpick] Inconsistent field naming: The field is named
vtablebut other interface objects in the same file use descriptive names likebroad_phase_layer_interface. Consider renaming todebug_rendererfor consistency with the established pattern.
vtable: *const VTable = zphy.DebugRenderer.initVTable(@This()),
acde055 to
2d7855d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update zphysics (zig-gamedev/zphysics#12)
Checklist:
physics_test_wgpubuilds and runs correctlymonolithbuilds and runs correctlyzphysics_instanced_cubes_d3d12builds and runs correctly