Feature/angular16 compatibility update #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- *.d.ts files are not added to the build output. Fixed these files - Removed unused files - Added production build config
- Remove karma-coverage-istanbul-reporter (outdated) - Replaced by: karma-coverage
…-compatibility-update
…-compatibility-update
This file only deploys the app and not the library. Building the library is redundant here.
`--base-href` flag needs to be set to the repo name since the Github Pages repo URL is "https://{userid}.github.io/{reponame}"
|
@jeanettephung, building the library before building the application in deploy.yaml is required to successfully build the app. |
Test using Chromeheadless to avoid Github actions being stuck during testing.
|
I commited a small fix to ensure Github Actions will correctly run test.yaml because Github requires Chromeheadless. |
Demo app requires the zingchart-angular dependency. Without this, the "deploy" github action will build app without this dependency and not render the charts. The `src/app/` components make references to this dependencies.
Support versions 16.2.0 to < 17
Support versions 16.2.0 to < 17
Remove comma I accidentally added
Update to match changes in package.json
Bramikke
commented
Sep 1, 2023
There was a problem hiding this comment.
projects/zingchart-angular/package.json
Please leave this on "latest" as setting a version here will prevent compatibility with future Angular versions.
By setting this, you oblige the user to install it's packages using --legacy-peer-deps. This is not ideal because it is possibly breaking other packages.
Bramikke
commented
Sep 1, 2023
Bramikke
commented
Sep 1, 2023
Reverting my changes. I see that the build fails and the app is now using the library instead of the library from the node modules directory.
Reverting my commit
Reverting since the app now uses the library instead of the npm package
Update to match package.json revert
Support angular 16.2.0 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Zingchart-angular to be compatible with future Angular versions
This pull request fixes issues with Angular 16 and up compatibility, introduces the migration from TSlint to ESlint, and fixes issues preventing compilation and workflow runs. The following changes have been made:
These changes collectively enhance code quality, maintainability, and future compatibility. Please review the modifications and provide your feedback.