Optimize Scope finalization for empty scopes #9477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
reviewed
Jan 20, 2025
Co-authored-by: Jules Ivanic <jules.ivanic@gmail.com>
hearnadam
reviewed
Jan 23, 2025
Comment on lines
+336
to
+337
| case Exit.Failure(c) if error eq null => error = c | ||
| case Exit.Failure(c) => error = error ++ c |
There was a problem hiding this comment.
Do these allocate an option?
There was a problem hiding this comment.
Hmmm not as far as I can tell. Why do you think they might?
There was a problem hiding this comment.
Can those 2 cases for Exit.Failure be replaces by just one:
case Exit.Failure(c) =>
error =
if (error eq null) c
else error ++ c
case _ => ()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added benchmark shows ~50% speedup when closing a scope that doesn't contain any finalizers. This is a quite common case especially when we're forking a scope as the finalizers are usually handled by the child scope