Skip to content

ensure unshare user has a valid name #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2022

Conversation

jameshilliard
Copy link

Prevents unshare wrapper from being used if the unshare wrapper user does not have a valid name as in #81.

@tomix26
Copy link
Collaborator

tomix26 commented May 8, 2022

Hi @jameshilliard, thanks very much for your contribution. I have just one question, wouldn't be possible to merge the new process builder with the previous one? Because both of these unshare commands seem quite similar to me.

@jameshilliard jameshilliard force-pushed the validate-unshare-name branch from 2bd242c to 4d17b2a Compare May 8, 2022 23:04
@jameshilliard
Copy link
Author

I have just one question, wouldn't be possible to merge the new process builder with the previous one?

Yeah, should be fine I think, updated to use previous process builder.

@tomix26
Copy link
Collaborator

tomix26 commented May 22, 2022

Yeah, should be fine I think, updated to use previous process builder.

I'm sorry, I wasn't clear enough. I meant to have only one invocation of the unshare command. So just modify the line 111 to have there builder.command("unshare", "-U", "id", "-un") without any following changes. Is this possible or not?

@jameshilliard
Copy link
Author

So just modify the line 111 to have there builder.command("unshare", "-U", "id", "-un") without any following changes. Is this possible or not?

I don't think so, since we need id -u as well to verify the UID is not 0.

@tomix26
Copy link
Collaborator

tomix26 commented May 22, 2022

Ok, thanks for the explanation and of course also thanks for the PR. Great job, as always. I really appreciate it.

@tomix26 tomix26 merged commit da6e2e6 into zonkyio:master May 22, 2022
@tomix26 tomix26 added this to the 2.0.1 milestone May 22, 2022
@jameshilliard jameshilliard deleted the validate-unshare-name branch May 22, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants