Use a function to bind keys #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPMo
requested changes
Nov 9, 2020
vi-increment.zsh
Outdated
Comment on lines
16
to
24
| bind_keys () { | ||
| local m | ||
| for m in vicmd visual; do | ||
| bindkey -M "$m" '^a' vi-increment | ||
| bindkey -M "$m" '^x' vi-decrement | ||
| done | ||
| } | ||
|
|
||
| bind_keys |
There was a problem hiding this comment.
Use an anyonymous function instead:
Suggested change
| bind_keys () { | |
| local m | |
| for m in vicmd visual; do | |
| bindkey -M "$m" '^a' vi-increment | |
| bindkey -M "$m" '^x' vi-decrement | |
| done | |
| } | |
| bind_keys | |
| () { | |
| local m | |
| for m in vicmd visual; do | |
| bindkey -M "$m" '^a' vi-increment | |
| bindkey -M "$m" '^x' vi-decrement | |
| done | |
| } |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
local mexecuted outside of a function it printsm=visualon zsh startup, also doesn't seem likelocalworks as intended outside a function - after shell startup I can access themvalue which was set in vi-increment.zsh