This changes enable the feature of saving images to the phone gallery. #483
Conversation
| // Re-enable camera controls | ||
| it.isEnabled = true | ||
| } | ||
| } | ||
|
|
||
| private fun takePhoto() { | ||
| val imageCapture = imageCapture ?: return |
There was a problem hiding this comment.
The whole PR looks very nice. Thanks a lot! Just one question: what is this line supposed to mean? You introduce a local variable with the same name and same value as the outer scope one? Is this supposed to simply check if imageCapture is null?
There was a problem hiding this comment.
Hi @axxel Good day.
Yes. This is to avoid application to crash in case of user clicks the button without it being completeb initialized.
Reference: https://medium.com/swlh/how-to-create-a-simple-camera-app-using-android-camerax-library-7367778498e0
Best regards.
|
After merging and testing your new feature I noticed that the image captured has a completely different resolution (and potentially orientation and aspect ratio) compared to the one in the ImageAnalysis path of the program. That is actually no surprise at all and surely what people normaly would be interested in (highest quality foto). In our use-case this is not the most useful data, though. What would be most useful is simply a 'save to file' copy of a single frame just as the zxing-cpp backend saw it. That is most useful for later debugging the image on a PC. I tried to quickly adjust the ImageCapture parameters to mimic the behavior of the ImageAnalysis path but it is not as straight forward as I'd hoped. Maybe the easiest was to achieve what I want would be to find some "save this image buffer as a JPG" code and then have the Since you were working on this just now, maybe you know what the quickest way to get to that result is? |
|
Hi @axxel I see what you're saying. Let me study the code a little more and see if we can come up with some way to do it.... I'll keep you posted. Thank you. |
Hi @axxel Good day.
Here's a new pull request to enable the image saving to gallery on the Android Demo App. I've tried to reduce it as much as possible keeping the original code intact as much as possible. Best regards.