WASM: bytes in ReadResult
#588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ten::val::global`
safely return bytes as `Uint8Array` in `ReadResult` via `emscripten::val::global`
axxel
reviewed
Jul 14, 2023
wrappers/wasm/BarcodeReader.cpp
Outdated
| for (auto&& result : results) { | ||
| readResults.push_back({ToString(result.format()), result.text(), std::string(result.bytes().asString()), | ||
| ToString(result.error()), result.position(), result.symbologyIdentifier()}); | ||
| ByteArray bytes = result.bytes(); |
There was a problem hiding this comment.
Very nice! I have one tiny improvement to suggest: this line makes a copy of result.bytes(), which is unnecessary. Either use result.bytes().data() below or change this line to const ByteArray& bytes = result.bytes(). I have not tested your changes myself, will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safely return bytes as
Uint8ArrayinReadResultviaemscripten::val::globalshould fix the issue mentioned in #584 and 8a0c458