Skip to content

Example for displaying QR codes in QML #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

UpdogCoder
Copy link

@UpdogCoder UpdogCoder commented Feb 18, 2024

Hi!
I've done some work on my project and was using the ZXing-C++ together with QML to display the QR codes. Because of that I wanted to add a basic example of doing that since the examples contain only reading the barcodes in QML.

Logic for generating the barcode is based on the methods from Qt Writer example by Axel and main goal was to show how to expose all of the generated stuff to QML.

Additionally added not in README about usage with Qt to indicate that it is possible to use ZXing-C++ directly with QML.

@axxel
Copy link
Collaborator

axxel commented Feb 19, 2024

Thanks for your contribution. Here are my thoughts:

  • please replace the space with tab based indentation (see .editorconfig / .clangformat)
  • the indentation in the CMakeLists.txt is off
  • you mentioned a change in some README but that is not part of the PR
  • would you be able to add a setting for the BarcodeFormat to make the sample a bit more usable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants