QR Code: add the possibility to set a fixed version #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are use cases where the generated QR Code must have fixed modules, no matter what the text length is. In this case, it's up to the user to choose a suitable QR Code version so that the text to be encoded fits.
Now that the MultiFormatWriter exposed the method to set the QR Code version, the same possibility has been added to the "CreateBarcode" methods defined under the ZXing experimental API.
The CLI example program gained the possibility to set the QR Code version now that both the MultiFormatWriter and the "CreateBarcode" methods defined under the ZXing experimental API exposed the related method.
|
Thanks for your effort. As laid out in #862, I'm considering an alternative approach for adding symbology specific configuration and result meta-information. You are welcome to join the discussion. |
|
There is progress on the string-based symbology specific parameter front. If you have ZXingWriter -size 500 microqrcode "1234" -options "version:2,datamask:0" out.png -v |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use cases where the generated QR Code must have fixed modules, no matter what the text length is.
These patches add the possibility to explicitly set the QR Code version.
It is the user responsibility to guarantee that the text to be encoded has a length that fits into the selected version.
The patches touch both the
MultiFormatWriterand theWriteBarcode"CreateBarcode" methods defined under the ZXing experimental API.Also the
ZXingWriterCLI example program has been updated, adding a new option.