Fix: Orca doesn't correctly announce swing components

Closes #29

See merge request !37

If the accessible context extends `AccessibleJComboBox` or `AccessibleJTree`, it will have a different class name but the same behavior.

orca#552
When navigating through nodes, JTree sends two signals: `object:selection-changed` and `object:active-descendant-changed`. The `object:selection-changed` signal is emitted before `object:active-descendant-changed`, leading to the following issues:
1. When focusing on the root of the tree, `object:active-descendant-changed` interrupts the announcement and does not provide any output because the FOCUS MANAGER doesn't update the focus — it is already set to the same object.
2. For other nodes, the correct behavior happens because of the bug in `JTree`: `AccessibleJTree` incorrectly reports the selected children and `object:selection-changed` sets focus on the tree.
Removing the `object:selection-changed` signal ensures that the locus of focus is updated during `object:active-descendant-changed`, allowing elements to be announced correctly.

JComboBox sends two signals: `object:active-descendant-changed` and `object:selection-changed`. Information about the component is announced when processing the `object:selection-changed` signal. The `object:active-descendant-changed` signal interrupts this announcement in earlier versions of GNOME. Skipping the emission of `object:active-descendant-changed` signal resolves the issue.

`focus_notify_handler` changes `ATK_STATE_SHOWING` by mistake

Closes #27

See merge request !36

It is a side effect of an unrelated change (`atk_focus_tracker_notify` was changed to `atk_object_notify_state_change`). The documentation for `atk_focus_tracker_notify` tells to use `atk_object_notify_state_change`, and talks about focus change, not showing change.

Tatiana Elfimova authored Oct 10, 2024 and Samuel Thibault committed Oct 30, 2024

Fixed issue: #25

Since ATK_STATE_COLLAPSED is only available starting with ATK-2.38, in earlier versions, collapsed objects are incorrectly marked as invalid, resulting in them not being spoken.

Fixed incorrect mapping of AccessibleRole.HYPERLINK

See merge request !35

Bug: #28
AccessibleRole.HYPERLINK corresponds to ATK_ROLE_LINK, not ATK_ROLE_UNKNOWN.

Ensure parent's finalize method is always called

See merge request !33

Moved `G_OBJECT_CLASS(jaw_object_parent_class)->finalize(gobject)` outside of conditional block to ensure that the parent's finalize method is always called, regardless of the state of jaw_obj->state_set.

Fixed incorrect method call

Closes #26

See merge request !32

`equalsIgnoreCaseLocaleWithRole` is static, so `GetStaticMethodID` should be used instead of `GetMethodID`. Otherwise, `jmethodID jmideic` will be null.

ATK_STATE_COLLAPSED is not actually a macro, so replace #ifdef with a
version check, since we know it appeared in atk 2.38.

Only use ATK_STATE_COLLAPSED if atk is new enough to support it,
and lower the atk requirement in meson.build.
Atk needs a release, so otherwise we depend on unreleased git code.

This is required if for some reason the AT_SPI_BUS property is not set.
That happens for instance if for some reason the dbus session bus (and thus
the at-spi bus) is reused between X sessions.

4ebe0720 ("Fixed bug 592987 - Java Combobox is not accessible")
made the collapsed java state mapped to ATK_STATE_EXPANDED instead of
ATK_STATE_DEFUNCT, then fd325d7d ("Fixed bug 593261 - Slider bar can
not be controled by gok") turned it to ATK_STATE_INVALID, but we do have
ATK_STATE_COLLAPSED which really does seem to match the collapsed java
state.

OpenJDK seems to be sending flurries of visible data changed events, which
overloads us. They are however usually just for the same object, so we can
compact them: there is no need to queue another one if the previous hasn't
even been sent!

because (0,0) is a valid position and Orca would happily use it

Details of role/states retrieval, and getting the jni env, is too verbose.
We however like to see the object name and role