Page MenuHomePhabricator
Create Task
Maniphest T139657

Fatal error: Invalid static property access: AbuseFilter::filters in AbuseFilterCheck.php on line 121
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

seen in logstash as of 1.28.0-wmf.9

Details

SubjectRepoBranchLines +/-
Make getFilter() public for extension hooksmediawiki/extensions/AbuseFilterwmf/1.28.0-wmf.10+1 -1
Make getFilter() public for extension hooksmediawiki/extensions/AbuseFiltermaster+1 -1
Avoid accessing private $filters fieldmediawiki/extensions/ContentTranslationwmf/1.28.0-wmf.10+1 -1
Avoid accessing private $filters fieldmediawiki/extensions/ContentTranslationmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• mmodell created this task.Jul 7 2016, 8:49 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 7 2016, 8:49 PM
matmarex assigned this task to aaron.Jul 15 2016, 9:31 PM
matmarex subscribed.

Probably caused by https://gerrit.wikimedia.org/r/#/c/296491/ (which was to fix other log spam: T138529).

gerritbot subscribed.Jul 15 2016, 9:55 PM

Change 299268 had a related patch set uploaded (by Aaron Schulz):
Make getFilter() public for extension hooks

https://gerrit.wikimedia.org/r/299268

gerritbot added a project: Patch-For-Review.Jul 15 2016, 9:55 PM
aaron merged a task: T140527: Fatal in CX extension includes/AbuseFilterCheck.php.Jul 16 2016, 6:08 AM
aaron added a subscriber: greg.
gerritbot added a comment.Jul 16 2016, 11:46 AM

Change 299268 merged by jenkins-bot:
Make getFilter() public for extension hooks

https://gerrit.wikimedia.org/r/299268

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-19_(1.28.0-wmf.11)).Jul 16 2016, 12:00 PM
gerritbot added a comment.Jul 17 2016, 6:19 AM

Change 299438 had a related patch set uploaded (by Aaron Schulz):
Avoid accessing private $filters field

https://gerrit.wikimedia.org/r/299438

matmarex added a project: ContentTranslation.Jul 18 2016, 3:46 PM
gerritbot added a comment.Jul 18 2016, 3:54 PM

Change 299438 merged by jenkins-bot:
Avoid accessing private $filters field

https://gerrit.wikimedia.org/r/299438

matmarex closed this task as Resolved.Jul 18 2016, 4:05 PM
matmarex removed a project: Patch-For-Review.
gerritbot added a comment.Jul 19 2016, 3:53 AM

Change 299707 had a related patch set uploaded (by BryanDavis):
Avoid accessing private $filters field

https://gerrit.wikimedia.org/r/299707

gerritbot added a project: Patch-For-Review.Jul 19 2016, 3:53 AM
gerritbot added a comment.Jul 19 2016, 3:34 PM

Change 299707 merged by jenkins-bot:
Avoid accessing private $filters field

https://gerrit.wikimedia.org/r/299707

Stashbot subscribed.Jul 19 2016, 3:49 PM

Mentioned in SAL [2016-07-19T15:49:28Z] <thcipriani@tin> Synchronized php-1.28.0-wmf.10/extensions/ContentTranslation/includes/AbuseFilterCheck.php: SWAT: [[gerrit:299707|Avoid accessing private $filters field (T139657)]] (duration: 00m 26s)

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)).Jul 19 2016, 4:00 PM
gerritbot added a comment.Jul 19 2016, 9:06 PM

Change 299862 had a related patch set uploaded (by Chad):
Make getFilter() public for extension hooks

https://gerrit.wikimedia.org/r/299862

gerritbot added a comment.Jul 19 2016, 9:40 PM

Change 299862 merged by jenkins-bot:
Make getFilter() public for extension hooks

https://gerrit.wikimedia.org/r/299862

• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jul 20 2016, 1:46 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits