⚓ T150706 Links in image captions are mangled

	Subject	Repo	Branch	Lines +/-
	Correct flex display for thumbnail contents on mobile	mediawiki/extensions/MobileFrontend	wmf/1.29.0-wmf.3	+6 -6
	Correct flex display for thumbnail contents on mobile	mediawiki/extensions/MobileFrontend	master	+6 -6

MaxSem created this task.Nov 14 2016, 10:01 PM

Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes, Aklapper. · View Herald TranscriptNov 14 2016, 10:01 PM

@TheDJ looks like this was caused by T148505 :-/

Jdlrobson updated the task description. (Show Details)Nov 15 2016, 4:20 PM

@Jdlrobson yup, i already noticed this morning. It seems that when i moved the style lines to hack.less, I got confused and moved the new styling into .thumbinner > div (the old style block), while it should have been on .thumbinner.

Annoyingly enough, that seems to not affect the layout of the images too much, but it does affect the display style of the children of .thumbcaption.

Will fix when I get home.

ovasileva moved this task from Incoming to 2014-15 Q4 on the Web-Team-Backlog board.Nov 15 2016, 6:09 PM

• jhobs moved this task from 2014-15 Q4 to Design on the Web-Team-Backlog board.Nov 15 2016, 6:09 PM

• jhobs edited projects, added Web-Team-Backlog (Design); removed Web-Team-Backlog.

• jhobs moved this task from Design to 2014-15 Q4 on the Web-Team-Backlog board.

• jhobs edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Design).

Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.Nov 15 2016, 6:11 PM

Jdlrobson added a project: Reading-Web-Sprint-85-💩.

Jdlrobson added a project: Unplanned-Sprint-Work.

Jdlrobson moved this task from 2014-15 Q4 to 2016-17 Q2 on the Web-Team-Backlog board.Nov 15 2016, 6:13 PM

Change 321708 had a related patch set uploaded (by TheDJ):
Correct flex display for thumbnail contents on mobile

https://gerrit.wikimedia.org/r/321708

gerritbot added a project: Patch-For-Review.Nov 15 2016, 7:22 PM

thanks for the report @MaxSem and thanks @TheDJ <3

Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-85-💩 board.Nov 16 2016, 10:13 AM

Change 321708 merged by jenkins-bot:
Correct flex display for thumbnail contents on mobile

https://gerrit.wikimedia.org/r/321708

Jdlrobson removed a project: Patch-For-Review.Nov 16 2016, 10:33 AM

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 16 2016, 11:00 AM

ovasileva closed this task as Resolved.Nov 16 2016, 1:19 PM

ovasileva claimed this task.

Change 322638 had a related patch set uploaded (by TheDJ):
Correct flex display for thumbnail contents on mobile

https://gerrit.wikimedia.org/r/322638

gerritbot added a project: Patch-For-Review.Nov 21 2016, 12:32 PM

Change 322638 merged by jenkins-bot:
Correct flex display for thumbnail contents on mobile

https://gerrit.wikimedia.org/r/322638

Mentioned in SAL (#wikimedia-operations) [2016-11-21T19:24:10Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.3/extensions/MobileFrontend/resources/skins.minerva.content.styles/hacks.less: SWAT: [[gerrit:322638|Correct flex display for thumbnail contents on mobile (T150706)]] (duration: 00m 59s)

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-15_(1.29.0-wmf.3)).Nov 27 2016, 11:01 PM

Jdlrobson mentioned this in T192251: Mapframes with a width of 100% fail to display on the mobile site unless "frameless" is used.Jun 4 2018, 6:21 PM

Links in image captions are mangled
Closed, ResolvedPublic
Actions

Description

Details

Related Objects

Event Timeline

	F4725769: Screenshot_20161114-135108.png
	Nov 14 2016, 10:01 PM

Links in image captions are mangledClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Links in image captions are mangled
Closed, ResolvedPublic
Actions