Page MenuHomePhabricator
Create Task
Maniphest T162114

CX2: Template adaptation
Closed, ResolvedPublic
Actions

Description

A problem with CX1 template adaptation is, the solution was not easily integratable to the references when reference definition is template.

There is also a consideration of VE template modeling and reusing it to model the CX template classes. Ofcourse we will require a pair of such models for source and target language.

Pending:

  • cxserver: Use the param mapping to build target template definition.
  • cxserver: Update tests for MWTemplate.js
  • cxserver: If template data not found, try to extract info from source code of template like we do in CX1 - ST working on.
  • The templates should be renderered in source and target language wikis instead of Localwiki. Customize ve.ce.MWTransclusionNode so that the api pointing to correct wikis
  • fetch the template data from correct wiki instead of localhost
  • T192271: CX2: Communicate template could not be adapted

Details

SubjectRepoBranchLines +/-
ve.init.mw.CXTarget: Customize parsefragmentmediawiki/extensions/ContentTranslationmaster+19 -0
CX2: Render templates in correct wikimediawiki/extensions/ContentTranslationmaster+118 -0
Templates: If templatedata not found, try to extract info from source codemediawiki/services/cxservermaster+65 -1
Template adaptation: Implement template param name matchingmediawiki/services/cxservermaster+281 -49
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedsanthoshT152586 Reorganize the CX classes using OOjs/OOUI (tracker)
OpenNoneT191389 CX2: Content type support (tracker)
ResolvedPginer-WMFT162114 CX2: Template adaptation
OpenNoneT171547 [wmf.10] Display of Template:Div_col on Translation page needs improvement
· · ·

Event Timeline

santhosh created this task.Apr 4 2017, 6:14 AM
Arrbee added a project: ContentTranslation-FY2017-18.Jun 27 2017, 3:21 PM
Arrbee moved this task from To Triage to CX-OOjs on the ContentTranslation-FY2017-18 board.
Amire80 moved this task from Needs Triage to Template Improvements on the ContentTranslation board.Jun 27 2017, 4:58 PM
Amire80 moved this task from Template Improvements to CX2 on the ContentTranslation board.
Arrbee reassigned this task from santhosh to Nikerabbit.Sep 20 2017, 7:13 AM
Arrbee mentioned this in T150652: Content Translation feature parity checklist post VisualEditor integration.Sep 20 2017, 8:41 AM
Arrbee edited projects, added Language-2017-July-Sept; removed Language-team April-June 2017.
Arrbee moved this task from Backlog to In Progress on the Language-2017-July-Sept board.
gerritbot added a comment.Sep 20 2017, 8:43 AM

Change 375789 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/services/cxserver@master] Adapt template names if present in Wikidata

https://gerrit.wikimedia.org/r/375789

gerritbot added a project: Patch-For-Review.Sep 20 2017, 8:43 AM
Nikerabbit added a comment.Sep 20 2017, 8:44 AM

Earlier patches related to this ticket:

Nikerabbit added a comment.Sep 27 2017, 3:31 PM

Per T150652: Content Translation feature parity checklist post VisualEditor integration I am currently working on template name adaptation (using Wikidata via interwiki links) and simple parameter mapping (exact & case insensitive matching using templatedata). This doesn't complete this ticket though.

Arrbee subscribed.Sep 28 2017, 6:47 AM
In T162114#3640008, @Nikerabbit wrote:

Per T150652: Content Translation feature parity checklist post VisualEditor integration I am currently working on template name adaptation (using Wikidata via interwiki links) and simple parameter mapping (exact & case insensitive matching using templatedata). This doesn't complete this ticket though.

Additional note: This is expected to complete the immediate priority items as per T150652: Content Translation feature parity checklist post VisualEditor integration. Further follow-up on template adaptation will also be determined by a final confirmation on the UI design expected for translation view.

gerritbot added a comment.Sep 29 2017, 9:35 AM

Change 381418 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Template adaptation: Implement template param name matching

https://gerrit.wikimedia.org/r/381418

santhosh added a comment.Oct 3 2017, 7:09 AM
This comment was removed by santhosh.
santhosh updated the task description. (Show Details)Oct 3 2017, 7:11 AM
gerritbot added a comment.Oct 3 2017, 8:30 AM

Change 381943 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Templates: If templatedata not found, try to extract info from source code

https://gerrit.wikimedia.org/r/381943

santhosh updated the task description. (Show Details)Oct 3 2017, 8:56 AM
Arrbee updated the task description. (Show Details)Oct 4 2017, 7:21 AM
Arrbee added a project: Language-2017-Oct-Dec.Oct 4 2017, 3:08 PM
Arrbee moved this task from Backlog to In Progress on the Language-2017-Oct-Dec board.Oct 4 2017, 3:12 PM
Arrbee moved this task from In Progress to Continued/Moved to future on the Language-2017-July-Sept board.Oct 4 2017, 3:23 PM
gerritbot added a comment.Oct 5 2017, 2:24 PM

Change 381418 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Template adaptation: Implement template param name matching

https://gerrit.wikimedia.org/r/381418

gerritbot added a comment.Oct 5 2017, 2:51 PM

Change 381943 merged by Nikerabbit:
[mediawiki/services/cxserver@master] Templates: If templatedata not found, try to extract info from source code

https://gerrit.wikimedia.org/r/381943

Arrbee updated the task description. (Show Details)Oct 10 2017, 5:36 PM
Arrbee moved this task from In Progress to Blocked on VE-CX on the Language-2017-Oct-Dec board.Oct 12 2017, 8:13 AM
Nikerabbit removed Nikerabbit as the assignee of this task.Nov 3 2017, 8:58 AM
Nikerabbit removed a project: Patch-For-Review.
Arrbee moved this task from CX2 to Blocked on VE-CX on the ContentTranslation board.Jan 4 2018, 6:27 PM
Arrbee removed a project: Language-2017-Oct-Dec.Jan 5 2018, 1:02 PM
Pginer-WMF added a project: Language-2018-Jan-Mar.Feb 20 2018, 8:38 AM
• Petar.petkovic added subscribers: Pginer-WMF, • Petar.petkovic.Mar 9 2018, 1:44 AM

Description of this ticket does not reflect what needs to be done in the future to resolve this. There are three bullet points, which are marked as checked.

Please update ticket description with required work for template adaption or create new ticket if this one doesn't suit the needs anymore. @Pginer-WMF, you may want to provide your inputs as well, just pinging you.

• Petar.petkovic moved this task from Blocked on VE-CX to CX2 on the ContentTranslation board.Mar 15 2018, 12:59 AM
Pginer-WMF added a project: Language-2018-Apr-June.Mar 28 2018, 10:01 AM
Pginer-WMF removed a project: Language-2018-Jan-Mar.Mar 28 2018, 10:17 AM
santhosh added a parent task: T191389: CX2: Content type support (tracker).Apr 4 2018, 9:37 AM
santhosh updated the task description. (Show Details)Apr 6 2018, 9:59 AM
gerritbot added a comment.Apr 6 2018, 9:59 AM

Change 424549 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] CX2: Render templates in correct wiki

https://gerrit.wikimedia.org/r/424549

gerritbot added a project: Patch-For-Review.Apr 6 2018, 9:59 AM
santhosh updated the task description. (Show Details)Apr 6 2018, 10:00 AM

After https://gerrit.wikimedia.org/r/424549, the adapted template having Tamil(target language) rendering

image.png (354×1 px, 55 KB)

• Petar.petkovic moved this task from Backlog to In Review on the Language-2018-Apr-June board.Apr 6 2018, 10:03 AM
santhosh claimed this task.Apr 6 2018, 11:46 AM
gerritbot added a comment.Apr 9 2018, 4:31 AM

Change 424983 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] ve.init.mw.CXTarget: Customize parsefragment

https://gerrit.wikimedia.org/r/424983

gerritbot added a comment.Apr 9 2018, 4:32 AM

Change 424549 abandoned by Santhosh:
CX2: Render templates in correct wiki

Reason:
Abandoning in favor of https://gerrit.wikimedia.org/r/c/424983/

https://gerrit.wikimedia.org/r/424549

gerritbot added a comment.Apr 10 2018, 8:04 AM

Change 424983 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] ve.init.mw.CXTarget: Customize parsefragment

https://gerrit.wikimedia.org/r/424983

• Petar.petkovic removed a project: Patch-For-Review.Apr 10 2018, 4:01 PM
• Petar.petkovic moved this task from In Review to QA on the Language-2018-Apr-June board.
Etonkovidova added a subtask: T171547: [wmf.10] Display of Template:Div_col on Translation page needs improvement .Apr 25 2018, 4:40 PM
Etonkovidova subscribed.May 1 2018, 12:59 AM

https://gerrit.wikimedia.org/r/424983 was deployed to wmf.1 - checked there (used the same example as @santhosh):

Screen Shot 2018-04-30 at 5.22.16 PM.png (437×913 px, 87 KB)

@santhosh is something else needs to be done regarding three remaining items on the ticket?

The templates should be renderered in source and target language wikis instead of Localwiki. Customize ve.ce.MWTransclusionNode so that the api pointing to correct wikis
Use the cx adaptation information to inform user about the status of template adaptation
fetch the template data from correct wiki instead of localhost

santhosh moved this task from QA to In Progress on the Language-2018-Apr-June board.May 2 2018, 3:55 AM

Yes, this ticket is not finished. We are yet to actually work on template support in frontend.

santhosh removed santhosh as the assignee of this task.May 2 2018, 3:55 AM
santhosh moved this task from CX2 to Needs Triage on the ContentTranslation board.
Etonkovidova added a comment.EditedMay 2 2018, 6:42 PM

Thx, @santhosh.

Arrbee moved this task from In Progress to Backlog on the Language-2018-Apr-June board.May 3 2018, 8:08 AM
Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.May 3 2018, 1:44 PM
Pginer-WMF mentioned this in T195760: Language Annual Plan 2018-2019.May 28 2018, 12:30 PM
Pginer-WMF edited projects, added Language-2018-July-September; removed Language-2018-Apr-June, Language-2017-July-Sept.Jun 25 2018, 9:40 AM
Arrbee removed a project: ContentTranslation-FY2017-18.Jun 25 2018, 11:22 AM
santhosh updated the task description. (Show Details)Aug 6 2018, 8:47 AM
Pginer-WMF closed this task as Resolved.Aug 6 2018, 8:49 AM
Pginer-WMF claimed this task.
Pginer-WMF updated the task description. (Show Details)

Most of the infrastructure work for template adaptation has been completed, and the remaining task has now a separate follow-up ticket: T192271: CX2: Communicate template could not be adapted

• Petar.petkovic moved this task from Backlog to Done on the Language-2018-July-September board.Aug 6 2018, 9:37 AM
Liuxinyu970226 unsubscribed.Aug 8 2018, 1:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits