Page MenuHomePhabricator
Create Task
Maniphest T188919

Integrate common CSS into the Page Content Service
Closed, ResolvedPublic
Actions

Description

I couldn't find an existing task for this but feel free to close as a duplicate if there is one (or adjust the parent task if that's incorrect).

One of RI's Q3 2017-18 goals is to: "Integrate common CSS into the Page Content Service." This is a task to define exactly what this should look like, so we can start building.

Open questions

  • Who are the intended consumers of this endpoint?
    • Should it be mobile-specific or general?
    • Is it intended primarily for consumption by WMF clients, or for general use?
  • Should this endpoint serve page-specific CSS, or only the common CSS currently needed for all Parsoid pages, such as the apps are bundling now?
  • How frequently do we envision clients requesting this for updates?
    • Note: we'll need to investigate what cache-control headers are set on the response by default and how much leeway we have on these.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

• Mholloway triaged this task as High priority.Mar 5 2018, 4:32 PM
• Mholloway created this task.
• Mholloway edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.
TheDJ subscribed.Mar 5 2018, 4:55 PM

Remember also upcoming changes due to deployment of TemplateStyles

gerritbot subscribed.Mar 8 2018, 11:25 PM

Change 417465 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] Initial CSS endpoint groundwork

https://gerrit.wikimedia.org/r/417465

gerritbot added a project: Patch-For-Review.Mar 8 2018, 11:25 PM
• Mholloway added a comment.Mar 9 2018, 2:13 PM

Hey @TheDJ, we're definitely looking forward to TemplateStyles! This endpoint (or its successor) will be working up to providing page-specific styles in future iterations; for now, to break ground on this work, we're just getting the existing app style bundle(s) behind an endpoint so they can be updated quickly without requiring an app release; then we can avoid situations like T185427, or deal with them much more quickly, in the future.

gerritbot added a comment.Mar 9 2018, 4:16 PM

Change 417971 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] CSS: Update routes for consolidated style modules

https://gerrit.wikimedia.org/r/417971

• Mholloway claimed this task.Mar 9 2018, 4:26 PM
• Mholloway moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
Tgr added a comment.Mar 9 2018, 7:42 PM

TemplateStyles embeds style tags in the parsed HTML (the feedback from the Performance team was that that will probably have the best perceived performance) so not really relevant for this service. Extensions which generate content and style it via ResourceLoader CSS are going to be more problematic.

gerritbot added a comment.Mar 12 2018, 5:58 PM

Change 417465 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Initial CSS endpoint groundwork

https://gerrit.wikimedia.org/r/417465

gerritbot added a comment.Mar 14 2018, 5:02 PM

Change 419477 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] CSS: Add mobile.app.parsoid to base styles

https://gerrit.wikimedia.org/r/419477

• Mholloway closed subtask T189312: Move special-case app styling from the MobileApp extension to PCS as Resolved.Mar 14 2018, 6:00 PM
gerritbot added a comment.Mar 16 2018, 9:19 PM

Change 417971 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] CSS: Update routes for consolidated style modules

https://gerrit.wikimedia.org/r/417971

• Mholloway reopened subtask T189312: Move special-case app styling from the MobileApp extension to PCS as Open.Mar 19 2018, 3:57 PM
gerritbot added a comment.Mar 19 2018, 4:48 PM

Change 420375 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/extensions/MobileApp@master] Remove enwiki.less

https://gerrit.wikimedia.org/r/420375

gerritbot added a comment.Mar 20 2018, 4:55 PM

Change 420764 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] Add /mobile/app/bundle endpoint for legacy app bundles

https://gerrit.wikimedia.org/r/420764

• Mholloway added a subtask: T190215: Unwanted styling on ul.gallery galleries from skins.minerva.content.styles.Mar 20 2018, 7:58 PM
• Mholloway closed subtask T190215: Unwanted styling on ul.gallery galleries from skins.minerva.content.styles as Invalid.Mar 20 2018, 8:30 PM
• Mholloway reopened subtask T190215: Unwanted styling on ul.gallery galleries from skins.minerva.content.styles as Open.
gerritbot added a comment.Mar 20 2018, 8:36 PM

Change 420844 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/extensions/MobileApp@master] Remove custom external link counter CSS

https://gerrit.wikimedia.org/r/420844

gerritbot added a comment.Mar 20 2018, 8:49 PM

Change 420847 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Update make-css-assets and bundled HTML/CSS

https://gerrit.wikimedia.org/r/420847

gerritbot added a comment.Mar 20 2018, 9:19 PM

Change 420904 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] CSS: Update base styles for bundling

https://gerrit.wikimedia.org/r/420904

• Mholloway closed subtask T190215: Unwanted styling on ul.gallery galleries from skins.minerva.content.styles as Invalid.Mar 21 2018, 3:19 PM
gerritbot added a comment.Mar 21 2018, 4:36 PM

Change 420844 merged by jenkins-bot:
[mediawiki/extensions/MobileApp@master] Remove custom external link counter CSS

https://gerrit.wikimedia.org/r/420844

gerritbot added a comment.Mar 21 2018, 4:57 PM

Change 420847 merged by jenkins-bot:
[apps/android/wikipedia@master] Update make-css-assets and bundled HTML/CSS

https://gerrit.wikimedia.org/r/420847

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 21 2018, 5:00 PM
gerritbot added a comment.Mar 21 2018, 7:19 PM

Change 420764 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Add /mobile/app/bundle endpoint for legacy app bundles

https://gerrit.wikimedia.org/r/420764

gerritbot added a comment.Mar 23 2018, 7:52 PM

Change 421613 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] CSS: Set max-age and s-maxage to 604800

https://gerrit.wikimedia.org/r/421613

gerritbot added a comment.Mar 26 2018, 4:58 PM

Change 421613 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] CSS: Set max-age and s-maxage to 604800

https://gerrit.wikimedia.org/r/421613

• Mholloway mentioned this in rAPIOS642f5e7ded35: Update handling of mobile site CSS.Mar 26 2018, 7:23 PM
gerritbot added a comment.Mar 26 2018, 8:21 PM

Change 422053 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Update handling of mobile site CSS

https://gerrit.wikimedia.org/r/422053

• Mholloway mentioned this in rAPIOScda5d942895c: Update handling of mobile site CSS.Mar 27 2018, 5:33 PM
gerritbot added a comment.Mar 27 2018, 9:15 PM

Change 422341 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] CSS: Add /site and /bundle endpoints to spec.yaml

https://gerrit.wikimedia.org/r/422341

• Mholloway mentioned this in T190569: Most images are not centered at mobile screen widths in Parsoid HTML.Mar 27 2018, 10:09 PM
gerritbot added a comment.Mar 28 2018, 1:58 PM

Change 422405 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] CSS: Drop max-age and s-maxage to one day

https://gerrit.wikimedia.org/r/422405

gerritbot added a comment.Mar 28 2018, 8:00 PM

Change 422405 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] CSS: Drop max-age and s-maxage to one day

https://gerrit.wikimedia.org/r/422405

gerritbot added a comment.Mar 28 2018, 8:01 PM

Change 422341 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] CSS: Add /site and /bundle endpoints to spec.yaml

https://gerrit.wikimedia.org/r/422341

gerritbot added a comment.Apr 3 2018, 6:05 PM

Change 419477 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] CSS: Add mobile.app.parsoid to base styles

https://gerrit.wikimedia.org/r/419477

gerritbot added a comment.Apr 3 2018, 6:05 PM

Change 420904 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] CSS: Update base styles for bundling

https://gerrit.wikimedia.org/r/420904

gerritbot added a comment.Apr 5 2018, 4:49 PM

Change 420375 merged by jenkins-bot:
[mediawiki/extensions/MobileApp@master] Remove enwiki.less

https://gerrit.wikimedia.org/r/420375

• Mholloway moved this task from Doing to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Apr 9 2018, 5:45 PM
• Mholloway closed this task as Resolved.Apr 12 2018, 2:35 PM
• Mholloway closed subtask T190091: Decide on a strategy for incorporating site-specific mobile CSS in the apps as Resolved.Apr 13 2018, 6:29 PM
gerritbot added a comment.Apr 17 2018, 4:09 PM

Change 427161 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] Sort Resource Loader modules alphabetically

https://gerrit.wikimedia.org/r/427161

gerritbot added a comment.Apr 17 2018, 7:55 PM

Change 427161 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Sort Resource Loader modules alphabetically

https://gerrit.wikimedia.org/r/427161

• Mholloway closed subtask T190846: CSS endpoint public rollout as Resolved.Apr 24 2018, 12:41 PM
gerritbot added a comment.Apr 24 2018, 5:24 PM

Change 422053 abandoned by Mholloway:
Update handling of mobile site CSS

Reason:
see Ib7bbbc79ddc626a7dceb81229f0a482092ad243f

https://gerrit.wikimedia.org/r/422053

• Jhernandez removed a subtask: T189312: Move special-case app styling from the MobileApp extension to PCS.Sep 11 2019, 12:41 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 11 2019, 1:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits